Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 9404014: If both -R and -D are specified when updating, remove all untracked directories (Closed)

Created:
8 years, 10 months ago by Steve Block
Modified:
8 years, 10 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel, Peter Mayo
Visibility:
Public.

Description

If both -R and -D are specified when updating, remove all untracked directories This is required to avoid the need to clobber the bots when moving a directory to deps/. Currently, the directory in question is likely to remain in the working copy, despite having been removed, due to the presence of untracked files. This causes the checkout from deps/ to fail. With this change, when both --reset and --delete_unversioned_trees are specified, the the directory in question will be removed from the working copy, thereby allowing the copy in deps/ to be checked out correctly. Note that untracked directories which are explicitly ignored (ie in .gitignore or svn:ignore) will not be removed. Note that this was previously landed in http://codereview.chromium.org/9348054 but reverted due to problems with symlinks in the chromeos build. BUG=112887, chromium-os:20759 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122300

Patch Set 1 #

Patch Set 2 : If both -R and -D are specified when updating, remove all untracked directories #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -15 lines) Patch
M gclient.py View 1 2 chunks +10 lines, -4 lines 0 comments Download
M gclient_scm.py View 1 3 chunks +31 lines, -5 lines 0 comments Download
M tests/gclient_scm_test.py View 1 5 chunks +142 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Steve Block
8 years, 10 months ago (2012-02-15 18:22:25 UTC) #1
Marc-Antoine Ruel (Google)
One nit, can you change all --force references to --reset? This way, we wouldn't have ...
8 years, 10 months ago (2012-02-15 18:55:25 UTC) #2
Steve Block
8 years, 10 months ago (2012-02-16 01:22:13 UTC) #3
Marc-Antoine Ruel (Google)
Sorry for the extreme sed'ing I forced you to do. lgtm Note that I'd prefer ...
8 years, 10 months ago (2012-02-16 01:39:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/9404014/2003
8 years, 10 months ago (2012-02-16 16:23:16 UTC) #5
commit-bot: I haz the power
Presubmit check for 9404014-2003 failed and returned exit status 1. warning: code.google.com certificate with fingerprint ...
8 years, 10 months ago (2012-02-16 16:29:18 UTC) #6
M-A Ruel
&±@)?/!!! lgtm
8 years, 10 months ago (2012-02-16 16:30:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/9404014/2003
8 years, 10 months ago (2012-02-16 16:30:42 UTC) #8
commit-bot: I haz the power
8 years, 10 months ago (2012-02-16 16:36:44 UTC) #9
Change committed as 122300

Powered by Google App Engine
This is Rietveld 408576698