webkit/plugins/ppapi/message_channel.cc - Issue 9403039: PPAPI: Really force-free NPObjects on Instance destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/message_channel.cc

Issue 9403039: PPAPI: Really force-free NPObjects on Instance destruction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/ppapi/message_channel.cc

diff --git a/webkit/plugins/ppapi/message_channel.cc b/webkit/plugins/ppapi/message_channel.cc

index f13911495eefa7155718377475590780d410b174..2dbd1fe8a6407f670774e65fc74469303795b504 100644

--- a/webkit/plugins/ppapi/message_channel.cc

+++ b/webkit/plugins/ppapi/message_channel.cc

@@ -412,7 +412,8 @@ MessageChannel::~MessageChannel() {

void MessageChannel::SetPassthroughObject(NPObject* passthrough) {

// Retain the passthrough object; We need to ensure it lives as long as this

// MessageChannel.

- WebBindings::retainObject(passthrough);

+ if (passthrough)

+ WebBindings::retainObject(passthrough);

// If we had a passthrough set already, release it. Note that we retain the

// incoming passthrough object first, so that we behave correctly if anyone

« no previous file with comments | « webkit/plugins/ppapi/host_var_tracker.cc ('k') | webkit/plugins/ppapi/npobject_var.h » ('j') | no next file with comments »