Refactor intra-strip panel drags by introducing PanelDragController.

chrome/browser/ui/panels/panel_overflow_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/panels/base_panel_browser_test.h"
 #include "chrome/browser/ui/panels/docked_panel_strip.h"
 #include "chrome/browser/ui/panels/native_panel.h"
 #include "chrome/browser/ui/panels/overflow_panel_strip.h"
@@ skipping 238 matching lines @@
 #define MAYBE_CreateMoreOverflowPanels CreateMoreOverflowPanels
 #define MAYBE_OverflowIndicatorCount OverflowIndicatorCount
 #define MAYBE_DrawOverflowAttention DrawOverflowAttention
 #else
 #define MAYBE_CreateMoreOverflowPanels DISABLED_CreateMoreOverflowPanels
 #define MAYBE_OverflowIndicatorCount DISABLED_OverflowIndicatorCount
 #define MAYBE_DrawOverflowAttention DISABLED_DrawOverflowAttention
 #endif
 
 IN_PROC_BROWSER_TEST_F(PanelOverflowBrowserTest, MAYBE_CheckPanelProperties) {
+  PanelManager* panel_manager = PanelManager::GetInstance();
+
   // Create 3 panels that fit.
   Panel* panel1 = CreatePanelWithBounds("1", gfx::Rect(0, 0, 250, 200));
   Panel* panel2 = CreatePanelWithBounds("2", gfx::Rect(0, 0, 300, 200));
   Panel* panel3 = CreatePanelWithBounds("3", gfx::Rect(0, 0, 200, 200));
 
   // Create an overflow panel without waiting for it to be moved to overflow.
   // Check its properties before and after it is moved to overflow.
   CreatePanelParams params(
       "4", gfx::Rect(0, 0, 255, 200), SHOW_AS_INACTIVE);
   params.wait_for_fully_created = false;
   Panel* panel4 = CreatePanelWithParams(params);
 
   EXPECT_EQ(Panel::EXPANDED, panel1->expansion_state());
   EXPECT_EQ(Panel::EXPANDED, panel2->expansion_state());
   EXPECT_EQ(Panel::EXPANDED, panel3->expansion_state());
   EXPECT_EQ(Panel::EXPANDED, panel4->expansion_state());
 
   EXPECT_FALSE(panel1->has_temporary_layout());
   EXPECT_FALSE(panel2->has_temporary_layout());
   EXPECT_FALSE(panel3->has_temporary_layout());
   EXPECT_TRUE(panel4->has_temporary_layout());
 
-  EXPECT_TRUE(panel1->draggable());
-  EXPECT_TRUE(panel2->draggable());
-  EXPECT_TRUE(panel3->draggable());
-  EXPECT_FALSE(panel4->draggable());
+  EXPECT_TRUE(panel_manager->CanDrag(panel1));
+  EXPECT_TRUE(panel_manager->CanDrag(panel2));
+  EXPECT_TRUE(panel_manager->CanDrag(panel3));
+  EXPECT_FALSE(panel_manager->CanDrag(panel4));
 
   // Make sure last panel really did overflow.
   WaitForLayoutModeChanged(panel4, PanelStrip::IN_OVERFLOW);
   EXPECT_FALSE(panel4->has_temporary_layout());
-  EXPECT_FALSE(panel4->draggable());
+  EXPECT_FALSE(panel_manager->CanDrag(panel4));
 
-  PanelManager::GetInstance()->CloseAll();
+  panel_manager->CloseAll();
 }
 
 IN_PROC_BROWSER_TEST_F(PanelOverflowBrowserTest, MAYBE_UpdateDraggableStatus) {
   PanelManager* panel_manager = PanelManager::GetInstance();
   Panel* panel = CreatePanel("panel");
-  EXPECT_TRUE(panel->draggable());
+  EXPECT_TRUE(panel_manager->CanDrag(panel));
   panel->MoveToStrip(panel_manager->overflow_strip());
-  EXPECT_FALSE(panel->draggable());
+  EXPECT_FALSE(panel_manager->CanDrag(panel));
   panel->MoveToStrip(panel_manager->docked_strip());
-  EXPECT_TRUE(panel->draggable());
+  EXPECT_TRUE(panel_manager->CanDrag(panel));
   panel->Close();
 }
 
 IN_PROC_BROWSER_TEST_F(PanelOverflowBrowserTest, MAYBE_CreateOverflowPanels) {
   PanelManager* panel_manager = PanelManager::GetInstance();
   DockedPanelStrip* docked_strip = panel_manager->docked_strip();
   OverflowPanelStrip* overflow_strip =
       panel_manager->overflow_strip();
 
   EXPECT_EQ(0, panel_manager->num_panels());
@@ skipping 1293 matching lines @@
   //   docked:               P0, P1, P5
   //   overflow:             P2, P10, P3, (P4, P6, P7, P9, P11)
   CloseWindowAndWait(panels[8]->browser());
   EXPECT_EQ(3, docked_strip->num_panels());
   EXPECT_EQ(8, overflow_strip->num_panels());
   EXPECT_TRUE(panels[3]->IsDrawingAttention());
   EXPECT_FALSE(overflow_indicator->IsDrawingAttention());
 
   panel_manager->CloseAll();
 }