src/objects.cc - Issue 9402008: Uniformly handle 'undefined' store to Float64Array and Float32Array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 9402008: Uniformly handle 'undefined' store to Float64Array and Float32Array. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 7bcccdf9fbf443424884f6f0b758c3e7a595c6a3..23f142e307ba0d87840e0888e25faf7d21da8029 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -11757,7 +11757,7 @@ MaybeObject* ExternalUnsignedIntArray::SetValue(uint32_t index, Object* value) {

MaybeObject* ExternalFloatArray::SetValue(uint32_t index, Object* value) {

- float cast_value = 0;

+ float cast_value = OS::nan_value();

Heap* heap = GetHeap();

if (index < static_cast<uint32_t>(length())) {

if (value->IsSmi()) {

@@ -11778,7 +11778,7 @@ MaybeObject* ExternalFloatArray::SetValue(uint32_t index, Object* value) {

MaybeObject* ExternalDoubleArray::SetValue(uint32_t index, Object* value) {

- double double_value = 0;

+ double double_value = OS::nan_value();

Heap* heap = GetHeap();

if (index < static_cast<uint32_t>(length())) {

if (value->IsSmi()) {

« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | test/mjsunit/external-array.js » ('J')