Uniformly handle 'undefined' store to Float64Array and Float32Array.

test/mjsunit/external-array.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 299 matching lines @@
     return a[0] = a[0] = 1;
   }
 
   array_load_set_smi_check2(a);
   %OptimizeFunctionOnNextCall(array_load_set_smi_check2);
   array_load_set_smi_check2(a);
   array_load_set_smi_check2(0);
   %DeoptimizeFunction(array_load_set_smi_check2);
   gc();  // Makes V8 forget about type information for array_load_set_smi_check.
 }
+
+// Check handling of undefined in 32- and 64-bit external float arrays.
+
+function store_float32_undefined(ext_array) {
+  for (var i = 0; i < 8; i++) {

[Michael Starzinger, 2012/02/15 13:39:29]

Is there a particular reason the assignment has to be done in a loop?

[danno, 2012/02/16 07:55:40]

Done.

+    ext_array[7] = undefined;
+  }
+}
+
+var float32_array = new Float32Array(8);
+// Make sure runtime does it right
+store_float32_undefined(float32_array);
+assertTrue(isNaN(float32_array[7]));
+// Make sure the ICs do it right
+store_float32_undefined(float32_array);
+assertTrue(isNaN(float32_array[7]));
+// Make sure that Cranskshft does it right.
+%OptimizeFunctionOnNextCall(store_float32_undefined);
+store_float32_undefined(float32_array);
+store_float32_undefined(float32_array);

[Michael Starzinger, 2012/02/15 13:39:29]

Is there a particular reason the store function is called twice here?

[danno, 2012/02/16 07:55:40]

Done.

+assertTrue(isNaN(float32_array[7]));
+
+function store_float64_undefined(ext_array) {
+  for (var i = 0; i < 8; i++) {

[Michael Starzinger, 2012/02/15 13:39:29]

Likewise.

[danno, 2012/02/16 07:55:40]

Done.

+    ext_array[7] = undefined;
+  }
+}
+
+var float64_array = new Float64Array(8);
+// Make sure runtime does it right
+store_float64_undefined(float64_array);
+assertTrue(isNaN(float64_array[7]));
+// Make sure the ICs do it right
+store_float64_undefined(float64_array);
+assertTrue(isNaN(float64_array[7]));
+// Make sure that Cranskshft does it right.
+%OptimizeFunctionOnNextCall(store_float64_undefined);
+store_float64_undefined(float64_array);
+store_float64_undefined(float64_array);

[Michael Starzinger, 2012/02/15 13:39:29]

Likewise.

[danno, 2012/02/16 07:55:40]

Done.

+assertTrue(isNaN(float64_array[7]));