Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 9401029: Android build: 64-bit linker issues. (Closed)

Created:
8 years, 10 months ago by John Grabowski
Modified:
8 years, 10 months ago
Reviewers:
Yaron, M-A Ruel
CC:
chromium-reviews, Satish, Peter Beverloo, Yaron
Visibility:
Public.

Description

Android build: 64-bit linker issues. Fix install-build-deps-android.sh so it can be re-run cheaply. Update install-build-deps-android.sh so it installs the 64-bit linker. Run install-build-deps-android.sh each build on the FYI bot. Move content_unittests to experimental so the FYI builder hits it. BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122665

Patch Set 1 #

Patch Set 2 : line ending issues #

Patch Set 3 : remove files that snuck in #

Patch Set 4 : replace both linkers #

Patch Set 5 : replace both linkers #

Patch Set 6 : col limit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -5 lines) Patch
M build/all_android.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M build/android/buildbot_functions.sh View 2 chunks +22 lines, -2 lines 0 comments Download
M build/android/buildbot_fyi.sh View 1 chunk +1 line, -0 lines 0 comments Download
M build/install-build-deps-android.sh View 1 2 3 4 5 3 chunks +40 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
John Grabowski
8 years, 10 months ago (2012-02-16 01:24:46 UTC) #1
M-A Ruel
lgtm
8 years, 10 months ago (2012-02-16 01:29:29 UTC) #2
Yaron
lgtm
8 years, 10 months ago (2012-02-17 22:28:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrg@chromium.org/9401029/9001
8 years, 10 months ago (2012-02-17 22:31:21 UTC) #4
commit-bot: I haz the power
Presubmit check for 9401029-9001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-17 22:31:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrg@chromium.org/9401029/12001
8 years, 10 months ago (2012-02-17 22:51:49 UTC) #6
commit-bot: I haz the power
8 years, 10 months ago (2012-02-18 01:58:46 UTC) #7
Change committed as 122665

Powered by Google App Engine
This is Rietveld 408576698