Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6623)

Unified Diff: chrome_frame/test/net/fake_external_tab.h

Issue 9401013: Don't run chrome_frame_net_tests URLRequestTestHTTP over loopback, due to mysterious failures. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Log the chosen hostname. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/test/net/fake_external_tab.h
diff --git a/chrome_frame/test/net/fake_external_tab.h b/chrome_frame/test/net/fake_external_tab.h
index be7e387ce06f6b7dbeed5bea7859d5a402fce483..51cd6c1aace156fbbfe0f850e383689c15ad75d0 100644
--- a/chrome_frame/test/net/fake_external_tab.h
+++ b/chrome_frame/test/net/fake_external_tab.h
@@ -21,6 +21,7 @@
#include "content/public/browser/browser_main_parts.h"
#include "content/public/browser/browser_thread.h"
#include "net/base/net_test_suite.h"
+#include "net/url_request/url_request_test_util.h"
class FakeBrowserProcessImpl;
class ProcessSingleton;
@@ -124,6 +125,8 @@ class CFUrlRequestUnittestRunner
bool running_with_crash_service_;
DWORD test_thread_id_;
+ scoped_ptr<CustomUrlRequestTestHttpHost> override_http_host_;
+
scoped_ptr<test_server::SimpleWebServer> test_http_server_;
test_server::SimpleResponse chrome_frame_html_;
@@ -133,6 +136,11 @@ class CFUrlRequestUnittestRunner
ScopedChromeFrameRegistrar registrar_;
int test_result_;
+ private:
+ // Causes HTTP tests to run over an external address rather than 127.0.0.1.
+ // See http://crbug.com/114369 .
+ void OverrideHttpHost();
+
DISALLOW_COPY_AND_ASSIGN(CFUrlRequestUnittestRunner);
};
« no previous file with comments | « no previous file | chrome_frame/test/net/fake_external_tab.cc » ('j') | chrome_frame/test/net/fake_external_tab.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698