Don't run chrome_frame_net_tests URLRequestTestHTTP over loopback, due to mysterious failures.

chrome_frame/test/net/fake_external_tab.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/test/net/fake_external_tab.h"
 
 #include <atlbase.h>
 #include <atlcom.h>
 #include <exdisp.h>
+#include <Winsock2.h>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/debugger.h"
 #include "base/file_util.h"
 #include "base/file_version_info.h"
 #include "base/i18n/icu_util.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
@@ skipping 29 matching lines @@
 #include "chrome_frame/test/simulate_input.h"
 #include "chrome_frame/test/win_event_receiver.h"
 #include "chrome_frame/utils.h"
 #include "content/app/content_main.h"
 #include "content/public/app/startup_helper_win.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_paths.h"
+#include "net/url_request/url_request_test_util.h"
 #include "sandbox/src/sandbox_types.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/ui_base_paths.h"
 
 using content::BrowserThread;
 
 namespace {
 
 // We must store this globally so that our main delegate can set it.
@@ skipping 500 matching lines @@
 
   DCHECK_EQ(test_thread_.IsValid(), false);
   test_thread_.Set(::CreateThread(NULL, 0, RunAllUnittests, this, 0,
                                   &test_thread_id_));
   DCHECK(test_thread_.IsValid());
 }
 
 // static
 DWORD CFUrlRequestUnittestRunner::RunAllUnittests(void* param) {
   base::PlatformThread::SetName("CFUrlRequestUnittestRunner");
+
+  char hostname[256];
+  struct hostent *host_info = NULL;

[eroman, 2012/02/16 02:35:14]

style-nit: asterisk goes on left.

+
+  LOG(ERROR) << "Calling gethostname.";

[eroman, 2012/02/16 02:35:14]

Please only log to LOG(ERROR) if an error actually occured. LOG(INFO) would be
more appropriate here.

+  if (0 != gethostname(hostname, arraysize(hostname))) {
+    LOG(ERROR) << "Failed to determine the local host name. Tests will be run "
+              << "over the loopback adapter, which may result in hangs.";

[eroman, 2012/02/16 02:35:14]

nit: indent by one more.

+
+  } else {
+    LOG(ERROR) << "hostname is " << hostname << " .";
+    if (NULL == (host_info = gethostbyname(hostname)) ||
+                 host_info->h_addrtype != AF_INET ||
+                 host_info->h_addr_list[0] == NULL) {
+      LOG(ERROR) << "Failed to look up addresses for the local host name. Tests "

[eroman, 2012/02/16 02:35:14]

line longer than 80

+                << "will be run over the loopback adapter, which may result in "
+                << "hangs.";
+    } else {
+      std::string host(
+        inet_ntoa(*reinterpret_cast<in_addr *>(host_info->h_addr_list[0])));

[eroman, 2012/02/16 02:35:14]

Are you able to use the net code here? If you are, there are some utility
functions which might help in net_util.h:

net::GetHostName()
net::AddressToString()

+
+      LOG(ERROR) << "chrome_frame_net_tests URLRequestTestHTTP will execute over "

[eroman, 2012/02/16 02:35:14]

long line.

+                 << "host IP address " << host << ".";
+
+      set_url_request_test_http_host(host);
+    }
+  }
+
   CFUrlRequestUnittestRunner* me =
       reinterpret_cast<CFUrlRequestUnittestRunner*>(param);
+
   me->test_result_ = me->Run();
   BrowserThread::PostTask(BrowserThread::UI,
                           FROM_HERE,
                           base::Bind(TakeDownBrowser, me));
   return 0;
 }
 
 // static
 void CFUrlRequestUnittestRunner::TakeDownBrowser(
     CFUrlRequestUnittestRunner* me) {
@@ skipping 158 matching lines @@
   // content::InitializeSandboxInfo(&sandbox_info);
   FakeMainDelegate delegate;
   content::ContentMain(
       reinterpret_cast<HINSTANCE>(GetModuleHandle(NULL)),
       &sandbox_info,
       &delegate);
 
   // Note:  In debug builds, we ExitProcess during PostDestroyThreads.
   return g_test_suite->test_result();
 }