Updated grammar, added resource argument to all functions.

Updated grammar, added resource argument to all functions.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122664

[brettw, 2012-02-15 20:39:34]

Can you also update the C++ wrappers? Those are mostly copy-n-paste of this
code, except the PP_Resource args are gone and some of the names are changed.

http://codereview.chromium.org/9401012/diff/3001/ppapi/api/ppb_view.idl
File ppapi/api/ppb_view.idl (right):

http://codereview.chromium.org/9401012/diff/3001/ppapi/api/ppb_view.idl#newco...
ppapi/api/ppb_view.idl:75: * IsVisible() determines whether the module instance
is visible to the user.
The plausibly part is important here, though maybe needs re-wording. The Chrome
window could be minimized, for example, or another window could be over it. In
both of these case the plugin is not visible, but we would return true. So all
you know from this is that if it returns false it's not visible, but if it
returns true, it "could be" visible.

http://codereview.chromium.org/9401012/diff/3001/ppapi/api/ppb_view.idl#newco...
ppapi/api/ppb_view.idl:119: * the visible rectangle (assuming the page was
visible). Refer to
I think this was better without the parens. The "assuming..." part is qualifying
the previous statement rather than providing a clarification for the same thing.
That is, it doesn't return the visible rectangle, it returns what the visible
rectangle is assuming the page is visible.

http://codereview.chromium.org/9401012/diff/3001/ppapi/api/ppb_view.idl#newco...
ppapi/api/ppb_view.idl:136: * be used for the first paint, and will be updated
later when your application
80 cols.

[jond, 2012-02-16 18:11:44]

On 2012/02/15 20:39:34, brettw wrote:
> Can you also update the C++ wrappers? Those are mostly copy-n-paste of this
> code, except the PP_Resource args are gone and some of the names are changed.

Yes, I will do that next after I get it right here first, then I'll copy and
paste and make the minor changes and submit to you. Okay?

> 
> http://codereview.chromium.org/9401012/diff/3001/ppapi/api/ppb_view.idl
> File ppapi/api/ppb_view.idl (right):
> 
>
http://codereview.chromium.org/9401012/diff/3001/ppapi/api/ppb_view.idl#newco...
> ppapi/api/ppb_view.idl:75: * IsVisible() determines whether the module
instance
> is visible to the user.
> The plausibly part is important here, though maybe needs re-wording. The
Chrome
> window could be minimized, for example, or another window could be over it. In
> both of these case the plugin is not visible, but we would return true. So all
> you know from this is that if it returns false it's not visible, but if it
> returns true, it "could be" visible.
> 
>
http://codereview.chromium.org/9401012/diff/3001/ppapi/api/ppb_view.idl#newco...
> ppapi/api/ppb_view.idl:119: * the visible rectangle (assuming the page was
> visible). Refer to
> I think this was better without the parens. The "assuming..." part is
qualifying
> the previous statement rather than providing a clarification for the same
thing.
> That is, it doesn't return the visible rectangle, it returns what the visible
> rectangle is assuming the page is visible.
> 
>
http://codereview.chromium.org/9401012/diff/3001/ppapi/api/ppb_view.idl#newco...
> ppapi/api/ppb_view.idl:136: * be used for the first paint, and will be updated
> later when your application
> 80 cols.

[jond, 2012-02-16 20:43:21]

http://codereview.chromium.org/9401012/diff/3001/ppapi/api/ppb_view.idl
File ppapi/api/ppb_view.idl (right):

http://codereview.chromium.org/9401012/diff/3001/ppapi/api/ppb_view.idl#newco...
ppapi/api/ppb_view.idl:75: * IsVisible() determines whether the module instance
is visible to the user.
On 2012/02/15 20:39:35, brettw wrote:
> The plausibly part is important here, though maybe needs re-wording. The
Chrome
> window could be minimized, for example, or another window could be over it. In
> both of these case the plugin is not visible, but we would return true. So all
> you know from this is that if it returns false it's not visible, but if it
> returns true, it "could be" visible.

Done.

http://codereview.chromium.org/9401012/diff/3001/ppapi/api/ppb_view.idl#newco...
ppapi/api/ppb_view.idl:119: * the visible rectangle (assuming the page was
visible). Refer to
On 2012/02/15 20:39:35, brettw wrote:
> I think this was better without the parens. The "assuming..." part is
qualifying
> the previous statement rather than providing a clarification for the same
thing.
> That is, it doesn't return the visible rectangle, it returns what the visible
> rectangle is assuming the page is visible.

Done.

http://codereview.chromium.org/9401012/diff/3001/ppapi/api/ppb_view.idl#newco...
ppapi/api/ppb_view.idl:136: * be used for the first paint, and will be updated
later when your application
On 2012/02/15 20:39:35, brettw wrote:
> 80 cols.

Done.

[brettw, 2012-02-16 23:44:28]

This looks good, I think you can update the C++ wrappers.

http://codereview.chromium.org/9401012/diff/7001/ppapi/api/ppb_view.idl
File ppapi/api/ppb_view.idl (right):

http://codereview.chromium.org/9401012/diff/7001/ppapi/api/ppb_view.idl#newco...
ppapi/api/ppb_view.idl:76: * the user. For example, the Chrome window could be
minimized or another window
80 cols.

[jond, 2012-02-17 16:07:27]

Need LGTM so I can check it in.

http://codereview.chromium.org/9401012/diff/7001/ppapi/api/ppb_view.idl
File ppapi/api/ppb_view.idl (right):

http://codereview.chromium.org/9401012/diff/7001/ppapi/api/ppb_view.idl#newco...
ppapi/api/ppb_view.idl:76: * the user. For example, the Chrome window could be
minimized or another window
On 2012/02/16 23:44:28, brettw wrote:
> 80 cols.

Done.

[jond, 2012-02-17 16:38:27]

Can you rubber stamp LGTM?

[brettw, 2012-02-17 18:05:11]

Oh, I thought you were going to add the C++ to this patch which is why I was
waiting. A separate pass is fine, too. LGTM

[commit-bot: I haz the power, 2012-02-17 22:08:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jond@google.com/9401012/12001

[commit-bot: I haz the power, 2012-02-18 01:58:35]

Change committed as 122664