Issue 9401011: Revert r121986 "If both -f and -D are specified when updating, remove all untracked directories"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9401011: Revert r121986 "If both -f and -D are specified when updating, remove all untracked directories" (Closed)

Created:
8 years, 10 months ago by M-A Ruel

Modified:
8 years, 10 months ago

Reviewers:
Peter Mayo, Steve Block

CC:
chromium-reviews, Peter Mayo, kliegs

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Revert r121986 "If both -f and -D are specified when updating, remove all untracked directories" Caused issues with chromium.chromiumos bots. TBR=steveblock@chromium.org BUG=112887 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122098

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -185 lines)			Patch
M	gclient.py	View	2 chunks	+4 lines, -9 lines	0 comments	Download
M	gclient_scm.py	View	4 chunks	+2 lines, -25 lines	0 comments	Download
M	tests/gclient_scm_test.py	View	6 chunks	+1 line, -151 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9401011/1

8 years, 10 months ago (2012-02-15 17:03:45 UTC) #2

Peter Mayo

8 years, 10 months ago (2012-02-15 17:11:29 UTC) #4

Kliegs:
  when this lands you are going to have to make sure your depot_tools doesn't
get updated past it to test the fix.

Others, FYI: we have a place to automate not creating things which hit this
safety check.  We are working on fixing ChromiumOS.  Once we have, we should
reapply.

Expand Messages | Collapse Messages