Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 9395077: [filebrowser] Introduce View action for supported file types (e.g. pdf). (Closed)

Created:
8 years, 10 months ago by dgozman
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org, mihaip+watch_chromium.org
Visibility:
Public.

Description

[filebrowser] Introduce "Open" action for supported file types (e.g. pdf). BUG=chromium-os:26538, chromium-os:26539 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125381

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -48 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 1 2 3 4 2 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 3 4 3 chunks +21 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/manifest.json View 1 2 3 4 1 chunk +26 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/filebrowser_component/main.js View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/filebrowser_component/read.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/filebrowser_component/write.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/filesystem_handler/manifest.json View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/filesystem_handler/tab.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/filesystem_handler_write/manifest.json View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/filesystem_handler_write/tab.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dgozman
Please, take a look.
8 years, 10 months ago (2012-02-20 16:23:35 UTC) #1
dgozman
Vlad, please take another look. I've added check for pdf plugin. Will add install-crx icon ...
8 years, 10 months ago (2012-02-21 15:31:41 UTC) #2
Vladislav Kaznacheev
lgtm
8 years, 10 months ago (2012-02-21 15:51:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9395077/10002
8 years, 9 months ago (2012-03-05 16:59:16 UTC) #4
commit-bot: I haz the power
Change committed as 124975
8 years, 9 months ago (2012-03-05 18:53:51 UTC) #5
dgozman
Zel, may you have a look at tests please? As I found out, tests are ...
8 years, 9 months ago (2012-03-06 15:28:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9395077/14001
8 years, 9 months ago (2012-03-07 10:22:36 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-07 12:05:36 UTC) #8
Change committed as 125381

Powered by Google App Engine
This is Rietveld 408576698