Fix muted audio when playback rate != 1.0 or 0.0

content/renderer/media/audio_renderer_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/audio_renderer_impl.h"
 
 #include <math.h>
 
 #include <algorithm>
 
@@ skipping 200 matching lines @@
         static_cast<int64>(ceil(request_delay.InMicroseconds() *
                                 GetPlaybackRate())));
   }
 
   uint32 bytes_per_frame =
       audio_parameters_.bits_per_sample * audio_parameters_.channels / 8;
 
   const size_t buf_size = number_of_frames * bytes_per_frame;
   scoped_array<uint8> buf(new uint8[buf_size]);
 
-  uint32 filled = FillBuffer(buf.get(), buf_size, request_delay);
-  DCHECK_LE(filled, buf_size);
-  UpdateEarliestEndTime(filled, request_delay, base::Time::Now());
-
-  uint32 filled_frames = filled / bytes_per_frame;
+  uint32 filled_frames = FillBuffer(buf.get(), number_of_frames, request_delay);

[acolwell GONE FROM CHROMIUM, 2012/02/22 07:51:40]

nit: rename frames_filled to be consistent with bytes_filled below.

[vrk (LEFT CHROMIUM), 2012/02/23 20:33:06]

Done.

+  uint32 bytes_filled = filled_frames * bytes_per_frame;
+  DCHECK_LE(bytes_filled, buf_size);
+  UpdateEarliestEndTime(bytes_filled, request_delay, base::Time::Now());
 
   // Deinterleave each audio channel.
   int channels = audio_data.size();
   for (int channel_index = 0; channel_index < channels; ++channel_index) {
     media::DeinterleaveAudioChannel(buf.get(),
                                     audio_data[channel_index],
                                     channels,
                                     channel_index,
                                     bytes_per_frame / channels,
                                     filled_frames);
@@ skipping 11 matching lines @@
 
 void AudioRendererImpl::OnRenderError() {
   host()->DisableAudioRenderer();
 }
 
 void AudioRendererImpl::OnRenderEndOfStream() {
   // TODO(enal): schedule callback instead of polling.
   if (base::Time::Now() >= earliest_end_time_)
     SignalEndOfStream();
 }