Issue 9392013: Try re-enabling DownloadsApiTest.Downloads on mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9392013: Try re-enabling DownloadsApiTest.Downloads on mac (Closed)

Created:
8 years, 10 months ago by benjhayden

Modified:
8 years, 10 months ago

Reviewers:
cbentzel, Randy Smith (Not in Mondays)

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, rdsmith+dwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Try re-enabling DownloadsApiTest.Downloads on mac Sheriffs, feel free to revert if it resumes failing on mac, or I can revert it for you. If it resumes failing on mac, then I'd like to add some debugging logs and try to fix it. BUG=101170

Patch Set 1 #

Patch Set 2 : merge #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	chrome/browser/download/download_extension_apitest.cc	View		1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cbentzel

Also, this should reference the bug about the disabled test in the CL description.

8 years, 10 months ago (2012-02-14 20:17:50 UTC) #2

Randy Smith (Not in Mondays)

8 years, 10 months ago (2012-02-14 23:15:20 UTC) #3

On 2012/02/14 20:17:50, cbentzel wrote:
> Also, this should reference the bug about the disabled test in  the CL
> description.

I'm comfortable going with Chris' review on this--I don't think I have extra
expertise to add.  (I.e. Rubber stamp LGTM.)

Expand Messages | Collapse Messages