Issue 9392001: MIPS: Port r10674 to x64 and arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9392001: MIPS: Port r10674 to x64 and arm. (Closed)

Created:
8 years, 10 months ago by kalmard

Modified:
8 years, 10 months ago

Reviewers:
kisg, Paul Lind, Yang, danno

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Port r10674 to x64 and arm. Port r10679 (cfd936). BUG= TEST=

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -2 lines)			Patch
	M	src/mips/builtins-mips.cc	View		3 chunks	+36 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2012/02/13 12:51:34, kalmard wrote: LGTM, but one comment. I'll land once it's been addressed.

8 years, 10 months ago (2012-02-13 13:14:48 UTC) #2

Yang

http://codereview.chromium.org/9392001/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): http://codereview.chromium.org/9392001/diff/1/src/mips/builtins-mips.cc#newcode420 src/mips/builtins-mips.cc:420: __ Addu(t3, t3, kPointerSize); you can skip the decrement ...

8 years, 10 months ago (2012-02-13 13:14:58 UTC) #3

Yang

8 years, 10 months ago (2012-02-14 09:15:11 UTC) #4

On 2012/02/13 13:14:58, Yang wrote:
> http://codereview.chromium.org/9392001/diff/1/src/mips/builtins-mips.cc
> File src/mips/builtins-mips.cc (right):
> 
>
http://codereview.chromium.org/9392001/diff/1/src/mips/builtins-mips.cc#newco...
> src/mips/builtins-mips.cc:420: __ Addu(t3, t3, kPointerSize);
> you can skip the decrement later if you do the increment after the smi-check.
> 
>
http://codereview.chromium.org/9392001/diff/1/src/mips/builtins-mips.cc#newco...
> src/mips/builtins-mips.cc:468: __ Subu(t3, t3, Operand(kPointerSize));
> this is the decrement I'm talking about in the previous comment.

Landed as http://codereview.chromium.org/9395003/

Expand Messages | Collapse Messages