Issue 9391027: Disable CREDENTIALS frames when using spdy/2.1 or earlier.

Issue 9391027: Disable CREDENTIALS frames when using spdy/2.1 or earlier. (Closed)

Created:
8 years, 10 months ago by Ryan Hamilton

Modified:
8 years, 10 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Disable CREDENTIALS frames when using spdy/2.1 or earlier. Add enum for spdy/3 which is used in CREDENTIAL frame unittests. BUG=113847 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121829

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
M	net/socket/ssl_client_socket.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/spdy/spdy_http_stream_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_session_unittest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

Hi Wan-Teh, This change disables CREDENTIAL frame for spdy/2.1 or earlier which should prevent the ...

8 years, 10 months ago (2012-02-14 00:51:36 UTC) #1

wtc

LGTM. https://chromiumcodereview.appspot.com/9391027/diff/4005/net/spdy/spdy_session.cc File net/spdy/spdy_session.cc (right): https://chromiumcodereview.appspot.com/9391027/diff/4005/net/spdy/spdy_session.cc#newcode556 net/spdy/spdy_session.cc:556: if (ssl_socket->protocol_negotiated() <= SSLClientSocket::kProtoSPDY21) Nit: it's safer to ...

8 years, 10 months ago (2012-02-14 00:57:36 UTC) #2

Ryan Hamilton

https://chromiumcodereview.appspot.com/9391027/diff/4005/net/spdy/spdy_session.cc File net/spdy/spdy_session.cc (right): https://chromiumcodereview.appspot.com/9391027/diff/4005/net/spdy/spdy_session.cc#newcode556 net/spdy/spdy_session.cc:556: if (ssl_socket->protocol_negotiated() <= SSLClientSocket::kProtoSPDY21) On 2012/02/14 00:57:36, wtc wrote: ...

8 years, 10 months ago (2012-02-14 00:58:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/9391027/2006

8 years, 10 months ago (2012-02-14 00:59:04 UTC) #4

Change committed as 121829

Expand Messages | Collapse Messages