Make a global enum to differentiate impl & proxy.

Make a global enum to differentiate impl & proxy.

Use this in resource constructors and remove all the old weird structs that we
used to tell which one to call. This removes some extra code we had to deal
with this.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121781

[brettw, 2012-02-13 21:19:17]

Pretty straightforward mechanical change. Trying to make it cleaner to write
"shared" resource objects.

[dmichael (off chromium), 2012-02-13 22:24:39]

http://codereview.chromium.org/9391013/diff/1/ppapi/shared_impl/resource.h
File ppapi/shared_impl/resource.h (right):

http://codereview.chromium.org/9391013/diff/1/ppapi/shared_impl/resource.h#ne...
ppapi/shared_impl/resource.h:109: const HostResource& host_resource);
Will this one ever be called with OBJECT_IS_IMPL? If not, is it worth passing
the parameter at all? If you want to keep it for the fact that it makes the
call-point self documenting, maybe it would make sense to DCHECK it?

[brettw, 2012-02-13 22:28:28]

http://codereview.chromium.org/9391013/diff/1/ppapi/shared_impl/resource.h
File ppapi/shared_impl/resource.h (right):

http://codereview.chromium.org/9391013/diff/1/ppapi/shared_impl/resource.h#ne...
ppapi/shared_impl/resource.h:109: const HostResource& host_resource);
Yes, in ppb_file_ref_shared.cc. That class needs to use a HostResource to
identify itself so that the PPB_FileRef_CreateInfo& struct can be shared.

[dmichael (off chromium), 2012-02-13 22:34:47]

lgtm

[commit-bot: I haz the power, 2012-02-13 22:36:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brettw@chromium.org/9391013/1

[commit-bot: I haz the power, 2012-02-14 00:27:07]

Change committed as 121781