Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: ui/gfx/render_text_linux.h

Issue 9390022: Simplify handling of BiDi cursor movement (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/render_text_linux.h
diff --git a/ui/gfx/render_text_linux.h b/ui/gfx/render_text_linux.h
index 79c87b002d2e2494d91860400fa52ae0387b9cfd..b8e658b59564f7523a7598ff65487083808f5744 100644
--- a/ui/gfx/render_text_linux.h
+++ b/ui/gfx/render_text_linux.h
@@ -21,10 +21,11 @@ class RenderTextLinux : public RenderText {
// Overridden from RenderText:
virtual base::i18n::TextDirection GetTextDirection() OVERRIDE;
- virtual int GetStringWidth() OVERRIDE;
+ virtual Size GetStringSize() OVERRIDE;
+ virtual void GetGlyphBounds(size_t index,
+ ui::Range* xspan,
+ int* height) OVERRIDE;
virtual SelectionModel FindCursorPosition(const Point& point) OVERRIDE;
- virtual Rect GetCursorBounds(const SelectionModel& position,
- bool insert_mode) OVERRIDE;
protected:
// Overridden from RenderText:
@@ -34,9 +35,7 @@ class RenderTextLinux : public RenderText {
virtual SelectionModel AdjacentWordSelectionModel(
const SelectionModel& selection,
VisualCursorDirection direction) OVERRIDE;
- virtual SelectionModel EdgeSelectionModel(
- VisualCursorDirection direction) OVERRIDE;
- virtual std::vector<Rect> GetSubstringBounds(size_t from, size_t to) OVERRIDE;
+ virtual std::vector<Rect> GetSubstringBounds(ui::Range range) OVERRIDE;
virtual void SetSelectionModel(const SelectionModel& model) OVERRIDE;
virtual bool IsCursorablePosition(size_t position) OVERRIDE;
virtual void UpdateLayout() OVERRIDE;
@@ -48,8 +47,9 @@ class RenderTextLinux : public RenderText {
size_t index,
LogicalCursorDirection direction) OVERRIDE;
- // Returns the run that contains |position|. Return NULL if not found.
- GSList* GetRunContainingPosition(size_t position) const;
+ // Returns the run that contains the character attached to the caret in the
+ // given selection model. Return NULL if not found.
+ GSList* GetRunContainingCaret(const SelectionModel& caret) const;
// Given |utf8_index_of_current_grapheme|, returns the UTF-8 index of the
// |next| or previous grapheme in logical order. Returns 0 if there is no
@@ -78,9 +78,9 @@ class RenderTextLinux : public RenderText {
size_t Utf16IndexToUtf8Index(size_t index) const;
size_t Utf8IndexToUtf16Index(size_t index) const;
- // Calculate the visual bounds containing the logical substring within |from|
- // to |to|.
- std::vector<Rect> CalculateSubstringBounds(size_t from, size_t to);
+ // Calculate the visual bounds containing the logical substring within the
+ // given range.
+ std::vector<Rect> CalculateSubstringBounds(ui::Range range);
// Get the visual bounds of the logical selection.
std::vector<Rect> GetSelectionBounds();
« no previous file with comments | « ui/gfx/render_text.cc ('k') | ui/gfx/render_text_linux.cc » ('j') | ui/gfx/render_text_linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698