chrome/browser/ui/gtk/location_bar_view_gtk.cc - Issue 9390015: Get rid of ShowPageInfo on WebContents and WebContentsDelegate. Chrome shouldn't have to go throu...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/location_bar_view_gtk.cc

Issue 9390015: Get rid of ShowPageInfo on WebContents and WebContentsDelegate. Chrome shouldn't have to go throu... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix gtk+mac Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm ('k') | chrome/browser/ui/views/location_bar/click_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/location_bar_view_gtk.cc

===================================================================

--- chrome/browser/ui/gtk/location_bar_view_gtk.cc (revision 121706)

+++ chrome/browser/ui/gtk/location_bar_view_gtk.cc (working copy)

@@ -70,6 +70,7 @@

#include "ui/gfx/image/image.h"

#include "webkit/glue/window_open_disposition.h"

+using content::NavigationController;

using content::NavigationEntry;

using content::OpenURLParams;

using content::WebContents;

@@ -1041,12 +1042,14 @@

if (event->x == 0 && event->y == 0)

return FALSE;

- NavigationEntry* nav_entry = tab->GetController().GetActiveEntry();

+ const NavigationController& controller = tab->GetController();

+ NavigationEntry* nav_entry = controller.GetActiveEntry();

if (!nav_entry) {

NOTREACHED();

return FALSE;

}

- tab->ShowPageInfo(nav_entry->GetURL(), nav_entry->GetSSL(), true);

+ Browser* browser = Browser::GetBrowserForController(&controller, NULL);

Ben Goodger (Google) 2012/02/14 17:52:56 You shouldn't need to do this. This object has a b

jam 2012/02/14 18:06:08 thanks, I missed that, i'll send you a cl updating

+ browser->ShowPageInfo(nav_entry->GetURL(), nav_entry->GetSSL(), true);

return TRUE;

} else if (event->button == 2) {

// When the user middle clicks on the location icon, try to open the