Implement C++ bindings generation in dartgenerator.py.

client/dom/scripts/dartgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module generates Dart APIs from the IDL database."""
 
 import emitter
 import idlnode
 import logging
@@ skipping 267 matching lines @@
         # Dart templates
         parent_type_name = type_name[0 : dart_template_match.start(1) - 1]
         sub_type_name = dart_template_match.group(1)
         return '%s<%s>' % (ConvertType(interface, parent_type_name),
                            ConvertType(interface, sub_type_name))
 
       return self._StripModules(type_name)
 
     for interface in database.GetInterfaces():
       for idl_type in interface.all(idlnode.IDLType):
+        original_type_name = idl_type.id
         idl_type.id = ConvertType(interface, idl_type.id)
+        # FIXME: remember original idl types that are needed by native
+        # generator. We should migrate other generators to idl registry and
+        # remove this hack.
+        if original_type_name != idl_type.id:
+          _original_idl_types[idl_type] = original_type_name
 
   def FilterInterfaces(self, database,
                        and_annotations=[],
                        or_annotations=[],
                        exclude_displaced=[],
                        exclude_suppressed=[]):
     """Filters a database to remove interfaces and members that are missing
     annotations.
 
     The FremontCut IDLs use annotations to specify implementation
@@ skipping 133 matching lines @@
       self._systems.append(html_system)
 
     if 'htmldartium' in systems:
       html_system = HtmlDartiumSystem(
           TemplateLoader(self._template_dir, ['html/dartium', 'html', '']),
           self._database, self._emitters, self._output_dir)
 
       html_system._interface_system = html_interface_system
       self._systems.append(html_system)
 
-
     # Collect interfaces
     interfaces = []
     for interface in database.GetInterfaces():
       if not _MatchSourceFilter(source_filter, interface):
         # Skip this interface since it's not present in the required source
         _logger.info('Omitting interface - %s' % interface.id)
         continue
       interfaces.append(interface)
 
     # TODO(sra): Use this list of exception names to generate information to
@@ skipping 13 matching lines @@
           super_database.HasInterface(super_name)):
         super_interface = super_name
 
       interface_name = interface.id
       auxiliary_file = self._auxiliary_files.get(interface_name)
       if auxiliary_file is not None:
         _logger.info('Skipping %s because %s exists' % (
             interface_name, auxiliary_file))
         continue
 
-
       info = _RecognizeCallback(interface)
       if info:
         for system in self._systems:
           system.ProcessCallback(interface, info)
       else:
         if 'Callback' in interface.ext_attrs:
           _logger.info('Malformed callback: %s' % interface.id)
         self._ProcessInterface(interface, super_interface,
                                source_filter, common_prefix)
 
@@ skipping 31 matching lines @@
                         source_filter,
                         common_prefix):
     """."""
     _logger.info('Generating %s' % interface.id)
 
     generators = [system.InterfaceGenerator(interface,
                                             common_prefix,
                                             super_interface_name,
                                             source_filter)
                   for system in self._systems]
+    generators = [g for g in generators if g]

[antonm, 2012/02/13 18:52:46]

filter(generators) might be more readable in this context even though
comprehensions are cute.

[podivilov, 2012/02/14 12:46:01]

Done.

 
     for generator in generators:
       generator.StartInterface()
 
     for const in sorted(interface.constants, ConstantOutputOrder):
       for generator in generators:
         generator.AddConstant(const)
 
     attributes = [attr for attr in interface.attributes
                   if not self._IsEventAttribute(interface, attr)]
@@ skipping 162 matching lines @@
   """Returns a list of (getter, setter) pairs sorted by name.
 
   One element of the pair may be None.
   """
   names = sorted(set(attr.id for attr in attributes))
   getters = {}
   setters = {}
   for attr in attributes:
     if attr.is_fc_getter:
       getters[attr.id] = attr
-    elif attr.is_fc_setter:
+    elif attr.is_fc_setter and 'Replaceable' not in attr.ext_attrs:
       setters[attr.id] = attr
   return [(getters.get(id), setters.get(id)) for id in names]
 
 
 def _AnalyzeOperation(interface, operations):
   """Makes operation calling convention decision for a set of overloads.
 
   Returns: An OperationInfo object.
   """
 
@@ skipping 1498 matching lines @@
     for getter, setter in event_attrs:
       event = getter or setter
       events_members.Emit(
           "\n"
           "EventListenerList get $NAME() => _get('$NAME');\n",
           NAME=event.id)
 
 
 # ------------------------------------------------------------------------------
 
+class IDLTypeInfo(object):
+  def __init__(self, idl_type, native_type='', ref_counted=True,
+               has_dart_wrapper=True,conversion_template=''):

[antonm, 2012/02/13 18:52:46]

nit: space after ,

[podivilov, 2012/02/14 12:46:01]

Done.

+    self._idl_type = idl_type
+    self._native_type = native_type
+    self._ref_counted = ref_counted
+    self._has_dart_wrapper = has_dart_wrapper
+    self._conversion_template = conversion_template
+
+  def idl_type(self):
+    return self._idl_type
+
+  def native_type(self):
+    if self._native_type != '':

[antonm, 2012/02/13 18:52:46]

nit: None might be more pythonic variant of missing value.

[podivilov, 2012/02/14 12:46:01]

Done.

+      return self._native_type
+    return self._idl_type
+
+  def parameter_adapter_info(self):
+    native_type = self.native_type()
+    if self._ref_counted:
+      native_type = 'RefPtr< %s >' % native_type
+    if self._has_dart_wrapper:
+      wrapper_type = 'Dart%s' % self.idl_type()
+      adapter_type = 'ParameterAdapter<%s, %s>' % (native_type, wrapper_type)
+      return (adapter_type, wrapper_type)
+    return ('ParameterAdapter< %s >' % native_type, self._idl_type)
+
+  def parameter_type(self):
+    return '%s*' % self.native_type()
+
+  def webcore_include(self):
+    if self._idl_type == 'SVGNumber' or self._idl_type == 'SVGPoint':
+      return ''

[antonm, 2012/02/13 18:52:46]

return None?

[podivilov, 2012/02/14 12:46:01]

Done.

+    if self._idl_type.startswith('SVGPathSeg'):
+      return self._idl_type.replace('Abs', '').replace('Rel', '')
+    return self._idl_type
+
+  def receiver(self):
+    return 'receiver->'
+
+  def conversion_include(self):
+    return 'Dart%s' % self._idl_type
+
+  def conversion_cast(self, expression):
+    if self._conversion_template != '':

[antonm, 2012/02/13 18:52:46]

nit: same for None

[podivilov, 2012/02/14 12:46:01]

Done.

+      return self._conversion_template % expression
+    return expression
+
+class PrimitiveIDLTypeInfo(IDLTypeInfo):
+  def __init__(self, idl_type, native_type='', ref_counted=False,
+               conversion_template=''):
+    super(PrimitiveIDLTypeInfo, self).__init__(idl_type,
+        native_type=native_type, ref_counted=ref_counted,
+        conversion_template=conversion_template)
+
+  def parameter_adapter_info(self):
+    native_type = self.native_type()
+    if self._ref_counted:
+      native_type = 'RefPtr< %s >' % native_type
+    return ('ParameterAdapter< %s >' % native_type, None)
+
+  def parameter_type(self):
+    if self._native_type == 'String':

[antonm, 2012/02/13 18:52:46]

_native_type or native_type() ?

[podivilov, 2012/02/14 12:46:01]

agreed, native_type() is better

+      return 'const String&'
+    return self.native_type()
+
+  def conversion_include(self):
+    return ''

[antonm, 2012/02/13 18:52:46]

return None?

[podivilov, 2012/02/14 12:46:01]

Done.

+
+
+class SVGTearOffIDLTypeInfo(IDLTypeInfo):
+  def __init__(self, idl_type, native_type='', ref_counted=True):
+    super(SVGTearOffIDLTypeInfo, self).__init__(idl_type,
+                                                ref_counted=ref_counted)
+    self._native_type = native_type

[antonm, 2012/02/13 18:52:46]

why this assignment?  maybe pass native_type instead?

[podivilov, 2012/02/14 12:46:01]

Done.

+
+  def native_type(self):
+    if self._native_type:
+      return self._native_type
+    tear_off_type = 'SVGPropertyTearOff'
+    if self._idl_type.endswith('List'):
+      tear_off_type = 'SVGListPropertyTearOff'
+    return '%s<%s>' % (tear_off_type, self._idl_type)
+
+  def receiver(self):
+    if self._idl_type.endswith('List'):
+      return 'receiver->'
+    return 'receiver->propertyReference().'
+
+
+_idl_type_registry = {
+    'boolean': PrimitiveIDLTypeInfo('boolean', native_type='bool', conversion_template='static_cast<bool>(%s)'),

[antonm, 2012/02/13 18:52:46]

why cast?

[podivilov, 2012/02/14 12:46:01]

There is GC3Dboolean which is not a bool, but unsigned char for OpenGL
compatibility. Added a comment.

+    'double': PrimitiveIDLTypeInfo('double'),
+    'int': PrimitiveIDLTypeInfo('int'),
+    'long': PrimitiveIDLTypeInfo('long', native_type='int'),
+    'long long': PrimitiveIDLTypeInfo('long long'),
+    'short': PrimitiveIDLTypeInfo('short', native_type='int', conversion_template='static_cast<int>(%s)'),
+    'unsigned int': PrimitiveIDLTypeInfo('unsigned int', native_type='unsigned'),
+    'unsigned long': PrimitiveIDLTypeInfo('unsigned long', native_type='unsigned'),
+    'unsigned long long': PrimitiveIDLTypeInfo('unsigned long long'),
+    'unsigned short': PrimitiveIDLTypeInfo('unsigned short', native_type='int', conversion_template='static_cast<int>(%s)'),

[antonm, 2012/02/13 18:52:46]

please, provide comments here and for short why casts are needed.

[podivilov, 2012/02/14 12:46:01]

Done.

+
+    'Date': PrimitiveIDLTypeInfo('Date',  native_type='double'),
+    'DOMString': PrimitiveIDLTypeInfo('DOMString',  native_type='String'),
+    'DOMTimeStamp': PrimitiveIDLTypeInfo('DOMTimeStamp'),
+    'object': PrimitiveIDLTypeInfo('object',  native_type='ScriptValue'),
+    'SerializedScriptValue': PrimitiveIDLTypeInfo('SerializedScriptValue', ref_counted=True),
+
+    'DOMException': IDLTypeInfo('DOMCoreException'),
+    'EventListener': IDLTypeInfo('EventListener', has_dart_wrapper=False),
+    'EventTarget': IDLTypeInfo('EventTarget', has_dart_wrapper=False),
+    'MediaQueryListListener': IDLTypeInfo('MediaQueryListListener', has_dart_wrapper=False),
+    'OptionsObject': IDLTypeInfo('OptionsObject', has_dart_wrapper=False),
+
+    'SVGAngle': SVGTearOffIDLTypeInfo('SVGAngle'),
+    'SVGLength': SVGTearOffIDLTypeInfo('SVGLength'),
+    'SVGLengthList': SVGTearOffIDLTypeInfo('SVGLengthList', ref_counted=False),
+    'SVGMatrix': SVGTearOffIDLTypeInfo('SVGMatrix'),
+    'SVGNumber': SVGTearOffIDLTypeInfo('SVGNumber', native_type='SVGPropertyTearOff<float>'),
+    'SVGNumberList': SVGTearOffIDLTypeInfo('SVGNumberList', ref_counted=False),
+    'SVGPathSegList': SVGTearOffIDLTypeInfo('SVGPathSegList', native_type='SVGPathSegListPropertyTearOff', ref_counted=False),
+    'SVGPoint': SVGTearOffIDLTypeInfo('SVGPoint', native_type='SVGPropertyTearOff<FloatPoint>'),
+    'SVGPointList': SVGTearOffIDLTypeInfo('SVGPointList', ref_counted=False),
+    'SVGPreserveAspectRatio': SVGTearOffIDLTypeInfo('SVGPreserveAspectRatio'),
+    'SVGRect': SVGTearOffIDLTypeInfo('SVGRect', native_type='SVGPropertyTearOff<FloatRect>'),
+    'SVGStringList': SVGTearOffIDLTypeInfo('SVGStringList', native_type='SVGStaticListPropertyTearOff<SVGStringList>', ref_counted=False),
+    'SVGTransform': SVGTearOffIDLTypeInfo('SVGTransform'),
+    'SVGTransformList': SVGTearOffIDLTypeInfo('SVGTransformList', native_type='SVGTransformListPropertyTearOff', ref_counted=False)
+}
+
+_original_idl_types = {
+}
+
+def GetIDLTypeInfo(idl_type):
+  if idl_type in _original_idl_types:

[antonm, 2012/02/13 18:52:46]

those 4 lines can be compressed to _original_idl_types.get(idl_type,
idl_type.id)

[podivilov, 2012/02/14 12:46:01]

That's nice!

+    idl_type_name = _original_idl_types[idl_type]
+  else:
+    idl_type_name = idl_type.id
+  return GetIDLTypeInfoByName(idl_type_name)
+
+def GetIDLTypeInfoByName(idl_type_name):
+  if idl_type_name in _idl_type_registry:

[antonm, 2012/02/13 18:52:46]

ditto

[podivilov, 2012/02/14 12:46:01]

Done.

+    return _idl_type_registry[idl_type_name]
+  return IDLTypeInfo(idl_type_name)
+
 class NativeImplementationSystem(System):
 
   def __init__(self, templates, database, emitters, auxiliary_dir, output_dir):
     super(NativeImplementationSystem, self).__init__(
         templates, database, emitters, output_dir)
 
     self._auxiliary_dir = auxiliary_dir
     self._dom_public_files = []
     self._dom_impl_files = []
     self._cpp_header_files = []
     self._cpp_impl_files = []
 
   def InterfaceGenerator(self,
                          interface,
                          common_prefix,
                          super_interface_name,
                          source_filter):
     interface_name = interface.id
 
     dart_interface_path = self._FilePathForDartInterface(interface_name)
     self._dom_public_files.append(dart_interface_path)
 
+    pure_interfaces = set([
+        'ElementTimeControl',
+        'ElementTraversal',
+        'MediaQueryListListener',
+        'NodeSelector',
+        'SVGExternalResourcesRequired',
+        'SVGFilterPrimitiveStandardAttributes',
+        'SVGFitToViewBox',
+        'SVGLangSpace',
+        'SVGLocatable',
+        'SVGStylable',
+        'SVGTests',
+        'SVGTransformable',
+        'SVGURIReference',
+        'SVGViewSpec',
+        'SVGZoomAndPan'])
+    if interface_name in pure_interfaces:
+      return None
+
     dart_impl_path = self._FilePathForDartImplementation(interface_name)
     self._dom_impl_files.append(dart_impl_path)
 
     cpp_header_path = self._FilePathForCppHeader(interface_name)
     self._cpp_header_files.append(cpp_header_path)
 
     cpp_impl_path = self._FilePathForCppImplementation(interface_name)
     self._cpp_impl_files.append(cpp_impl_path)
 
     return NativeImplementationGenerator(interface, super_interface_name,
         self._emitters.FileEmitter(dart_impl_path),
         self._emitters.FileEmitter(cpp_header_path),
         self._emitters.FileEmitter(cpp_impl_path),
         self._BaseDefines(interface),
         self._templates)
 
   def ProcessCallback(self, interface, info):
-    self._dom_public_files.append(self._FilePathForDartInterface(interface.id))
+    self._interface = interface
+
+    dart_interface_path = self._FilePathForDartInterface(self._interface.id)
+    self._dom_public_files.append(dart_interface_path)
+
+    cpp_header_handlers_emitter = emitter.Emitter()
+    cpp_impl_handlers_emitter = emitter.Emitter()
+    class_name = 'Dart%s' % self._interface.id
+    for operation in interface.operations:
+      return_type = 'void'
+      return_statement = 'm_callback.handleEvent(%s);' % ', '.join([a.id for a in operation.arguments])
+      if operation.type.id != 'void':
+        return_type = 'bool'
+        return_statement = 'return %s' % return_statement
+
+      parameters = []
+      for argument in operation.arguments:
+        argument_type_info = GetIDLTypeInfo(argument.type)
+        parameters.append('%s %s' % (argument_type_info.parameter_type(),
+                                     argument.id))
+
+      cpp_header_handlers_emitter.Emit(
+          '\n'
+          '    virtual $TYPE handleEvent($PARAMETERS);\n',
+          TYPE=return_type, PARAMETERS=', '.join(parameters))
+
+      cpp_impl_handlers_emitter.Emit(
+          '\n'
+          '$TYPE $CLASS_NAME::handleEvent($PARAMETERS)\n'
+          '{\n'
+          '    $RETURN_STATEMENT\n'

[antonm, 2012/02/13 18:52:46]

maybe provide ; here and not at ln. 2447

[podivilov, 2012/02/14 12:46:01]

Done.

+          '}\n',
+          TYPE=return_type,
+          CLASS_NAME=class_name,
+          PARAMETERS=', '.join(parameters),
+          RETURN_STATEMENT=return_statement)
+
+    cpp_header_path = self._FilePathForCppHeader(self._interface.id)
+    cpp_header_emitter = self._emitters.FileEmitter(cpp_header_path)
+    cpp_header_emitter.Emit(
+        self._templates.Load('cpp_callback_header.template'),
+        INTERFACE=self._interface.id,
+        HANDLERS=cpp_header_handlers_emitter.Fragments())
+
+    cpp_impl_path = self._FilePathForCppImplementation(self._interface.id)
+    self._cpp_impl_files.append(cpp_impl_path)
+    cpp_impl_emitter = self._emitters.FileEmitter(cpp_impl_path)
+    cpp_impl_emitter.Emit(
+        self._templates.Load('cpp_callback_implementation.template'),
+        INTERFACE=self._interface.id,
+        HANDLERS=cpp_impl_handlers_emitter.Fragments())
 
   def GenerateLibraries(self, lib_dir):
     auxiliary_dir = os.path.relpath(self._auxiliary_dir, self._output_dir)
 
     # Generate dom_public.dart.
     self._GenerateLibFile(
         'dom_public.darttemplate',
         os.path.join(self._output_dir, 'dom_public.dart'),
         self._dom_public_files,
         AUXILIARY_DIR=auxiliary_dir);
@@ skipping 31 matching lines @@
           '    if (Dart_NativeFunction func = $CLASS_NAME::resolver(name, argumentCount))\n'
           '        return func;\n',
           CLASS_NAME=os.path.splitext(os.path.basename(path))[0])
 
     cpp_resolver_emitter = self._emitters.FileEmitter(cpp_resolver_path)
     cpp_resolver_emitter.Emit(
         self._templates.Load('cpp_resolver.template'),
         INCLUDES=includes_emitter.Fragments(),
         RESOLVER_BODY=resolver_body_emitter.Fragments())
 
+    # Generate DartDerivedSourcesAll.cpp
+    cpp_all_in_one_path = os.path.join(self._output_dir,
+        'DartDerivedSourcesAll.cpp')
+
+    includes_emitter = emitter.Emitter()
+    for file in self._cpp_impl_files:
+        path = os.path.relpath(file, os.path.dirname(cpp_all_in_one_path))
+        includes_emitter.Emit('#include "$PATH"\n', PATH=path)
+
+    cpp_all_in_one_emitter = self._emitters.FileEmitter(cpp_all_in_one_path)
+    cpp_all_in_one_emitter.Emit(
+        self._templates.Load('cpp_all_in_one.template'),
+        INCLUDES=includes_emitter.Fragments())
+
+    # Generate DartResolver.cpp
+    cpp_resolver_path = os.path.join(self._output_dir, 'DartResolver.cpp')
+
+    includes_emitter = emitter.Emitter()
+    resolver_body_emitter = emitter.Emitter()
+    for file in self._cpp_header_files:
+        path = os.path.relpath(file, os.path.dirname(cpp_resolver_path))
+        includes_emitter.Emit('#include "$PATH"\n', PATH=path)
+        resolver_body_emitter.Emit(
+            '    if (Dart_NativeFunction func = $CLASS_NAME::resolver(name, argumentCount))\n'
+            '        return func;\n',
+            CLASS_NAME=os.path.splitext(os.path.basename(path))[0])
+
+    cpp_resolver_emitter = self._emitters.FileEmitter(cpp_resolver_path)
+    cpp_resolver_emitter.Emit(
+        self._templates.Load('cpp_resolver.template'),
+        INCLUDES=includes_emitter.Fragments(),
+        RESOLVER_BODY=resolver_body_emitter.Fragments())
+
   def Finish(self):
     pass
 
   def _FilePathForDartInterface(self, interface_name):
     return os.path.join(self._output_dir, 'src', 'interface',
                         '%s.dart' % interface_name)
 
   def _FilePathForDartImplementation(self, interface_name):
     return os.path.join(self._output_dir, 'dart',
                         '%sImplementation.dart' % interface_name)
@@ skipping 32 matching lines @@
     self._super_interface = super_interface
     self._dart_impl_emitter = dart_impl_emitter
     self._cpp_header_emitter = cpp_header_emitter
     self._cpp_impl_emitter = cpp_impl_emitter
     self._base_members = base_members
     self._templates = templates
     self._current_secondary_parent = None
 
   def StartInterface(self):
     self._class_name = self._ImplClassName(self._interface.id)
+    self._interface_type_info = GetIDLTypeInfoByName(self._interface.id)
     self._members_emitter = emitter.Emitter()
+    self._cpp_declarations_emitter = emitter.Emitter()
+    self._cpp_impl_includes = {}
+    self._cpp_definitions_emitter = emitter.Emitter()
+    self._cpp_resolver_emitter = emitter.Emitter()
+
+    # Generate constructor.
+    if ('CustomConstructor' in self._interface.ext_attrs or
+        'V8CustomConstructor' in self._interface.ext_attrs or
+        self._interface.id in ['FileReader', 'WebKitCSSMatrix']):

[antonm, 2012/02/13 18:52:46]

maybe put this information into type registry?

[podivilov, 2012/02/14 12:46:01]

This check is a temporary hack from old generator. I'm trying to add hacks in
place rather than to type registry. Added a fixme to add proper support for
non-custom constructors.

+      self._cpp_resolver_emitter.Emit(
+          '    if (name == "$(INTERFACE_NAME)_constructor_Callback")\n'
+          '        return Dart$(INTERFACE_NAME)Internal::constructorCallback;\n',
+          INTERFACE_NAME=self._interface.id)
+      self._cpp_declarations_emitter.Emit(
+          '\n'
+          'void constructorCallback(Dart_NativeArguments);\n')
 
   def _ImplClassName(self, interface_name):
     return interface_name + 'Implementation'
 
   def FinishInterface(self):
     base = self._BaseClassName(self._interface)
     self._dart_impl_emitter.Emit(
         self._templates.Load('dart_implementation.darttemplate'),
         CLASS=self._class_name, BASE=base, INTERFACE=self._interface.id,
         MEMBERS=self._members_emitter.Fragments())
 
-    self._cpp_header_emitter.Emit(
-        self._templates.Load('cpp_header.template'),
-        INTERFACE=self._interface.id)
+    self._GenerateCppHeader()
 
     self._cpp_impl_emitter.Emit(
         self._templates.Load('cpp_implementation.template'),
-        INTERFACE=self._interface.id)
+        INTERFACE=self._interface.id,
+        INCLUDES=''.join(['#include "%s.h"\n' %
+          k for k in self._cpp_impl_includes.keys()]),
+        CALLBACKS=self._cpp_definitions_emitter.Fragments(),
+        RESOLVER=self._cpp_resolver_emitter.Fragments())
+
+  def _GenerateCppHeader(self):
+    webcore_include = self._interface_type_info.webcore_include()
+    if webcore_include:
+      webcore_include = '#include "%s.h"\n' % webcore_include
+
+    if ('CustomToJS' in self._interface.ext_attrs or
+        'PureInterface' in self._interface.ext_attrs or
+        self._interface.id in ['DOMWindow', 'Element', 'HTMLElement', 'SVGElement']):

[antonm, 2012/02/13 18:52:46]

ditto for type registry

[podivilov, 2012/02/14 12:46:01]

Done.

+      to_dart_value_template = (
+          'Dart_Handle toDartValue($(WEBCORE_CLASS_NAME)* value);\n')
+    else:
+      to_dart_value_template = (
+          'inline Dart_Handle toDartValue($(WEBCORE_CLASS_NAME)* value)\n'
+          '{\n'
+          '    return DartDOMWrapper::toDart<Dart$(INTERFACE)>(value);\n'
+          '}\n')
+    to_dart_value_emitter = emitter.Emitter()
+    to_dart_value_emitter.Emit(
+        to_dart_value_template,
+        INTERFACE=self._interface.id,
+        WEBCORE_CLASS_NAME=self._interface_type_info.native_type())
+
+    self._cpp_header_emitter.Emit(
+        self._templates.Load('cpp_header.template'),
+        INTERFACE=self._interface.id,
+        WEBCORE_INCLUDE=webcore_include,
+        ADDITIONAL_INCLUDES='',
+        WEBCORE_CLASS_NAME=self._interface_type_info.native_type(),
+        TO_DART_VALUE=to_dart_value_emitter.Fragments(),
+        DECLARATIONS=self._cpp_declarations_emitter.Fragments())
 
   def AddAttribute(self, getter, setter):
+    # FIXME: Dartium does not support attribute event listeners. However, JS
+    # implementation falls back to them when addEventListener is not available.
+    # Make sure addEventListener is available in all EventTargets and remove
+    # this check.
+    if (getter or setter).type.id == 'EventListener':
+      return
+
+    # FIXME: support 'ImplementedBy'.
+    if 'ImplementedBy' in (getter or setter).ext_attrs:
+      return
+
+    # FIXME: these should go away.
+    classes_with_unsupported_custom_getters = [
+        'Clipboard', 'Console', 'Coordinates', 'DeviceMotionEvent',
+        'DeviceOrientationEvent', 'FileReader', 'JavaScriptCallFrame',
+        'HTMLInputElement', 'HTMLOptionsCollection', 'HTMLOutputElement',
+        'ScriptProfileNode', 'WebKitAnimation']
+    if (self._interface.id in classes_with_unsupported_custom_getters and
+        getter and set(['Custom', 'CustomGetter']) & set(getter.ext_attrs)):
+      return
+
     if getter:
       self._AddGetter(getter)
     if setter:
       self._AddSetter(setter)
 
   def _AddGetter(self, attr):
-    self._members_emitter.Emit(
-        '\n'
-        '  $TYPE get $NAME() native "$(INTERFACE)_$(NAME)_Getter";\n',
-        NAME=attr.id, TYPE=attr.type.id, INTERFACE=self._interface.id)
+    dart_declaration = '%s get %s()' % (attr.type.id, attr.id)
+    is_custom = 'Custom' in attr.ext_attrs or 'CustomGetter' in attr.ext_attrs
+    cpp_callback_name = self._GenerateNativeBinding(attr.id, 1,
+        dart_declaration, 'Getter', is_custom)
+    if is_custom:
+      return
+
+    arguments = []
+    if 'Reflect' in attr.ext_attrs:
+      idl_type = GetIDLTypeInfo(attr.type).idl_type()

[antonm, 2012/02/13 18:52:46]

again, type registry?

[podivilov, 2012/02/14 12:46:01]

Done.

+      webcore_function_name = 'getAttribute'
+      if 'URL' in attr.ext_attrs:
+        if 'NonEmpty' in attr.ext_attrs:
+          webcore_function_name = 'getNonEmptyURLAttribute'
+        else:
+          webcore_function_name = 'getURLAttribute'
+      elif idl_type == 'boolean':
+        webcore_function_name = 'hasAttribute'
+      elif idl_type == 'long':
+        webcore_function_name = 'getIntegralAttribute'
+      elif idl_type == 'unsigned long':
+        webcore_function_name = 'getUnsignedIntegralAttribute'
+      arguments.append(self._GenerateWebCoreReflectionAttributeName(attr))
+    else:
+      if attr.id == 'operator':
+        webcore_function_name = '_operator'
+      elif attr.id == 'target' and attr.type.id == 'SVGAnimatedString':
+        webcore_function_name = 'svgTarget'
+      else:
+        webcore_function_name = re.sub(r'^(HTML|URL|JS|XML|XSLT|\w)',
+                                       lambda s: s.group(1).lower(),
+                                       attr.id)
+        webcore_function_name = re.sub(r'^(create|exclusive)',
+                                       lambda s: 'is' + s.group(1).capitalize(),
+                                       webcore_function_name)
+      if attr.type.id.startswith('SVGAnimated'):
+        webcore_function_name += 'Animated'
+
+    self._GenerateNativeCallback(cpp_callback_name, attr, '',
+        webcore_function_name, arguments, idl_return_type=attr.type,
+        raises_dart_exceptions=attr.get_raises,
+        raises_dom_exceptions=attr.get_raises)
 
   def _AddSetter(self, attr):
-    self._members_emitter.Emit(
-        '\n'
-        '  void set $NAME($TYPE) native "$(INTERFACE)_$(NAME)_Setter";\n',
-        NAME=attr.id, TYPE=attr.type.id, INTERFACE=self._interface.id)
+    dart_declaration = 'void set %s(%s)' % (attr.id, attr.type.id)
+    is_custom = set(['Custom', 'CustomSetter', 'V8CustomSetter']) & set(attr.ext_attrs)
+    cpp_callback_name = self._GenerateNativeBinding(attr.id, 2,
+        dart_declaration, 'Setter', is_custom)
+    if is_custom:
+      return
+
+    arguments = []
+    if 'Reflect' in attr.ext_attrs:
+      idl_type = GetIDLTypeInfo(attr.type).idl_type()
+      webcore_function_name = 'setAttribute'
+      if idl_type == 'boolean':
+        webcore_function_name = 'setBooleanAttribute'
+      elif idl_type == 'long':
+        webcore_function_name = 'setIntegralAttribute'
+      elif idl_type == 'unsigned long':
+        webcore_function_name = 'setUnsignedIntegralAttribute'
+      arguments.append(self._GenerateWebCoreReflectionAttributeName(attr))
+    else:
+      webcore_function_name = re.sub(r'^(xml(?=[A-Z])|\w)',
+                                     lambda s: s.group(1).upper(),
+                                     attr.id)
+      webcore_function_name = 'set%s' % webcore_function_name
+      if attr.type.id.startswith('SVGAnimated'):
+        webcore_function_name += 'Animated'
+
+    arguments.append(attr.id)
+    parameter_definitions_emitter = emitter.Emitter()
+    self._GenerateParameterAdapter(parameter_definitions_emitter, attr, 0)
+    parameter_definitions = parameter_definitions_emitter.Fragments()
+    self._GenerateNativeCallback(cpp_callback_name, attr, parameter_definitions,
+        webcore_function_name, arguments, idl_return_type=None,
+        raises_dart_exceptions=True,
+        raises_dom_exceptions=attr.set_raises)
 
   def _HasNativeIndexGetter(self, interface):
     return ('HasCustomIndexGetter' in interface.ext_attrs or
             'HasNumericIndexGetter' in interface.ext_attrs)
 
   def _EmitNativeIndexGetter(self, interface, element_type):
-    native_binding = '%s_numericIndexGetter_Callback' % interface.id
-    self._members_emitter.Emit(
-        '\n'
-        '  $TYPE operator[](int index) native "$NATIVE_BINDING";\n',
-        TYPE=element_type, NATIVE_BINDING=native_binding)
+    dart_declaration = '%s operator[](int index)' % element_type
+    self._GenerateNativeBinding('numericIndexGetter', 2, dart_declaration,
+        'Callback', True)
 
   def _EmitNativeIndexSetter(self, interface, element_type):
-    native_binding = '%s_numericIndexSetter_Callback' % self._interface.id
-    self._members_emitter.Emit(
-        '\n'
-        '  void operator[]=(int index, $TYPE value) native "$NATIVE_BINDING";\n',
-        TYPE=element_type, NATIVE_BINDING=native_binding)
+    dart_declaration = 'void operator[]=(int index, %s value)' % element_type
+    self._GenerateNativeBinding('numericIndexSetter', 3, dart_declaration,
+        'Callback', True)
 
   def AddOperation(self, info):
     """
     Arguments:
       info: An OperationInfo object.
     """
 
     if 'Custom' in info.overloads[0].ext_attrs:
-        self._members_emitter.Emit(
-            '\n'
-            '  $TYPE $NAME($PARAMETERS) native "$(INTERFACE)_$(NAME)_Callback";\n',
-            TYPE=info.type_name,
-            NAME=info.name,
-            PARAMETERS=info.ParametersImplementationDeclaration(),
-            INTERFACE=self._interface.id)
-        return
+      parameters = info.ParametersImplementationDeclaration()
+      dart_declaration = '%s %s(%s)' % (info.type_name, info.name, parameters)
+      argument_count = 1 + len(info.arg_infos)
+      self._GenerateNativeBinding(info.name, argument_count, dart_declaration,
+          'Callback', True)
+      return
 
     body = self._members_emitter.Emit(
         '\n'
         '  $TYPE $NAME($PARAMETERS) {\n'
         '$!BODY'
         '  }\n',
         TYPE=info.type_name,
         NAME=info.name,
         PARAMETERS=info.ParametersImplementationDeclaration())
 
     # Process in order of ascending number of arguments to ensure missing
     # optional arguments are processed early.
     overloads = sorted(info.overloads,
                        key=lambda overload: len(overload.arguments))
     self._native_version = 0
     fallthrough = self.GenerateDispatch(body, info, '    ', 0, overloads)
     if fallthrough:
       body.Emit('    throw "Incorrect number or type of arguments";\n');
 
-  def GenerateSingleOperation(self,  emitter, info, indent, operation):
+  def GenerateSingleOperation(self,  dispatch_emitter, info, indent, operation):
     """Generates a call to a single operation.
 
     Arguments:
-      emitter: an Emitter for the body of a block of code.
+      dispatch_emitter: an dispatch_emitter for the body of a block of code.
       info: the compound information about the operation and its overloads.
       indent: an indentation string for generated code.
       operation: the IDLOperation to call.
     """
 
-    arg_names = [info.arg_infos[i][0]
-                 for (i, arg) in enumerate(operation.arguments)]
+    # FIXME: support ImplementedBy callbacks.
+    if 'ImplementedBy' in operation.ext_attrs:
+      return
+
+    for op in self._interface.operations:
+      if op.id != operation.id or len(op.arguments) <= len(operation.arguments):
+        continue
+      next_argument = op.arguments[len(operation.arguments)]
+      if next_argument.is_optional and 'Callback' in next_argument.ext_attrs:
+        # FIXME: '[Optional, Callback]' arguments could be non-optional in
+        # webcore. We need to fix overloads handling to generate native
+        # callbacks properly.
+        return
 
     self._native_version += 1
-    native_name = '_%s' % info.name
+    native_name = info.name
     if self._native_version > 1:
       native_name = '%s_%s' % (native_name, self._native_version)
-
-    argument_expressions = ', '.join(arg_names)
+    argument_list = ', '.join([info.arg_infos[i][0]
+                               for (i, arg) in enumerate(operation.arguments)])
+
+    # Generate dispatcher.
     if info.type_name != 'void':
-      emitter.Emit('$(INDENT)return $NATIVENAME($ARGS);\n',
-                   INDENT=indent,
-                   NATIVENAME=native_name,
-                   ARGS=argument_expressions)
+      dispatch_emitter.Emit('$(INDENT)return _$NATIVENAME($ARGS);\n',
+                            INDENT=indent,
+                            NATIVENAME=native_name,
+                            ARGS=argument_list)
     else:
-      emitter.Emit('$(INDENT)$NATIVENAME($ARGS);\n'
-                   '$(INDENT)return;\n',
-                   INDENT=indent,
-                   NATIVENAME=native_name,
-                   ARGS=argument_expressions)
-
-    self._members_emitter.Emit('  $TYPE $NATIVE_NAME($PARAMS) native '
-                               '"$(INTERFACE)$(NATIVE_NAME)_Callback";\n',
-                               NATIVE_NAME=native_name,
-                               TYPE=info.type_name,
-                               PARAMS=', '.join(arg_names),
-                               INTERFACE=self._interface.id)
+      dispatch_emitter.Emit('$(INDENT)_$NATIVENAME($ARGS);\n'
+                            '$(INDENT)return;\n',
+                            INDENT=indent,
+                            NATIVENAME=native_name,
+                            ARGS=argument_list)
+    # Generate binding.
+    dart_declaration = '%s _%s(%s)' % (info.type_name, native_name,
+                                       argument_list)
+    is_custom = 'Custom' in operation.ext_attrs
+    cpp_callback_name = self._GenerateNativeBinding(
+        native_name, 1 + len(operation.arguments), dart_declaration, 'Callback',
+        is_custom)
+    if is_custom:
+      return
+
+    # Generate callback.
+    webcore_function_name = operation.id
+    if 'ImplementationFunction' in operation.ext_attrs:
+      webcore_function_name = operation.ext_attrs['ImplementationFunction']
+
+    parameter_definitions_emitter = emitter.Emitter()
+    raises_dart_exceptions = len(operation.arguments) > 0 or operation.raises
+    arguments = []
+
+    # Process 'CallWith' argument.
+    if ('CallWith' in operation.ext_attrs and
+        operation.ext_attrs['CallWith'] == 'ScriptExecutionContext'):
+      parameter_definitions_emitter.Emit(
+          '        ScriptExecutionContext* context = DartUtilities::scriptExecutionContext();\n'
+          '        if (!context)\n'
+          '            return;\n')
+      arguments.append('context')
+
+    # Process Dart arguments.
+    for (i, argument) in enumerate(operation.arguments):
+      if i == len(operation.arguments) - 1 and 'CustomArgumentHandling' in operation.ext_attrs:
+        # FIXME: we are skipping last argument here because it was added in
+        # supplemental dart.idl. Cleanup dart.idl and remove this check.
+        break
+      self._GenerateParameterAdapter(parameter_definitions_emitter, argument, i)
+      arguments.append(argument.id)
+
+    if operation.id in ['addEventListener', 'removeEventListener']:
+      # addEventListener's and removeEventListener's last argument is marked
+      # as optional in idl, but is not optional in webcore implementation.
+      if len(operation.arguments) == 2:
+        arguments.append('false')
+
+    if self._interface.id == 'CSSStyleDeclaration' and operation.id == 'setProperty':
+      # CSSStyleDeclaration.setProperty priority parameter is optional in Dart
+      # idl, but is not optional in webcore implementation.
+      if len(operation.arguments) == 2:
+        arguments.append('String()')
+
+    # Process auxiliary arguments.
+    if 'CustomArgumentHandling' in operation.ext_attrs:
+      raises_dart_exceptions = True
+      self._cpp_impl_includes['ScriptArguments'] = 1
+      self._cpp_impl_includes['ScriptCallStack'] = 1
+      self._cpp_impl_includes['V8Proxy'] = 1
+      self._cpp_impl_includes['v8'] = 1
+      parameter_definitions_emitter.Emit(
+          '        v8::HandleScope handleScope;\n'

[antonm, 2012/02/13 18:52:46]

separate template file?

[podivilov, 2012/02/14 12:46:01]

It's convenient to have small snippets inline, I think we should not use
template here.

+          '        v8::Context::Scope scope(V8Proxy::mainWorldContext(DartUtilities::domWindowForCurrentIsolate()->frame()));\n'
+          '        Dart_Handle customArgument = Dart_GetNativeArgument(args, $INDEX);\n'
+          '        RefPtr<ScriptArguments> scriptArguments(DartUtilities::createScriptArguments(customArgument, exception));\n'
+          '        if (!scriptArguments)\n'
+          '            goto fail;\n'
+          '        RefPtr<ScriptCallStack> scriptCallStack(DartUtilities::createScriptCallStack());\n'
+          '        if (!scriptCallStack->size())\n'
+          '            return;\n',
+          INDEX=len(operation.arguments))
+      arguments.extend(['scriptArguments', 'scriptCallStack'])
+
+    if 'NeedsUserGestureCheck' in operation.ext_attrs:
+      arguments.extend('DartUtilities::processingUserGesture')
+
+    parameter_definitions = parameter_definitions_emitter.Fragments()
+    self._GenerateNativeCallback(cpp_callback_name, operation,
+        parameter_definitions, webcore_function_name, arguments,
+        idl_return_type=operation.type,
+        raises_dart_exceptions=raises_dart_exceptions,
+        raises_dom_exceptions=operation.raises)
+
+  def _GenerateNativeCallback(self, callback_name, idl_node,
+      parameter_definitions, function_name, arguments, idl_return_type,
+      raises_dart_exceptions, raises_dom_exceptions):
+    receiver = self._interface_type_info.receiver()
+    if raises_dom_exceptions:
+      arguments.append('ec')
+    callback = '%s%s(%s)' % (receiver, function_name, ', '.join(arguments))
+
+    nested_templates = []
+    if idl_return_type and idl_return_type.id != 'void':
+      return_type_info = GetIDLTypeInfo(idl_return_type)
+      conversion_cast = return_type_info.conversion_cast('$BODY')
+      if isinstance(return_type_info, SVGTearOffIDLTypeInfo):
+        svg_primitive_types = ['SVGAngle', 'SVGLength', 'SVGMatrix',
+            'SVGNumber', 'SVGPoint', 'SVGRect', 'SVGTransform']
+        conversion_cast = '%s::create($BODY)'
+        if self._interface.id.startswith('SVGAnimated'):
+          conversion_cast = 'static_cast<%s*>($BODY)'
+        elif return_type_info.idl_type() == 'SVGStringList':
+          conversion_cast = '%s::create(receiver, $BODY)'
+        elif self._interface.id.endswith('List'):
+          conversion_cast = 'static_cast<%s*>($BODY.get())'
+        elif return_type_info.idl_type() in svg_primitive_types:
+          conversion_cast = '%s::create($BODY)'
+        else:
+          conversion_cast = 'static_cast<%s*>($BODY)'
+        conversion_cast = conversion_cast % return_type_info.native_type()
+      nested_templates.append(conversion_cast)
+
+      if return_type_info.conversion_include():
+        self._cpp_impl_includes[return_type_info.conversion_include()] = 1
+      if (return_type_info.idl_type() in ['DOMString', 'AtomicString'] and
+          'ConvertNullStringTo' in idl_node.ext_attrs):
+        nested_templates.append('$BODY, ConvertDefaultToNull')
+      nested_templates.append(
+          '        Dart_Handle returnValue = toDartValue($BODY);\n'
+          '        if (returnValue)\n'
+          '            Dart_SetReturnValue(args, returnValue);\n')
+    else:
+      nested_templates.append('        $BODY;\n')
+
+    if raises_dom_exceptions:
+      nested_templates.append(
+          '        ExceptionCode ec = 0;\n'
+          '$BODY'
+          '        if (UNLIKELY(ec)) {\n'
+          '            exception = DartDOMWrapper::exceptionCodeToDartException(ec);\n'
+          '            goto fail;\n'
+          '        }\n')
+
+    nested_templates.append(
+        '    {\n'
+        '        $WEBCORE_CLASS_NAME* receiver = DartDOMWrapper::receiver< $WEBCORE_CLASS_NAME >(args);\n'
+        '$PARAMETER_DEFINITIONS'
+        '\n'
+        '$BODY'
+        '        return;\n'
+        '    }\n')
+
+    if raises_dart_exceptions:
+      nested_templates.append(
+          '    Dart_Handle exception;\n'
+          '$BODY'
+          '\n'
+          'fail:\n'
+          '    Dart_ThrowException(exception);\n'
+          '    ASSERT_NOT_REACHED();\n')
+
+    nested_templates.append(
+        '\n'
+        'static void $CALLBACK_NAME(Dart_NativeArguments args)\n'
+        '{\n'
+        '    DartApiScope dartApiScope;\n'
+        '$BODY'
+        '}\n')
+
+    template_parameters = {
+        'CALLBACK_NAME': callback_name,
+        'WEBCORE_CLASS_NAME': self._interface_type_info.native_type(),
+        'PARAMETER_DEFINITIONS': parameter_definitions,
+    }
+    for template in nested_templates:
+      template_parameters['BODY'] = callback
+      callback_emitter = emitter.Emitter()
+      callback_emitter.Emit(template, **template_parameters)
+      callback = ''.join(callback_emitter.Fragments())
+
+    self._cpp_definitions_emitter.Emit(callback)
+
+  def _GenerateParameterAdapter(self, emitter, idl_argument, index):
+    type_info = GetIDLTypeInfo(idl_argument.type)
+    (adapter_type, include_name) = type_info.parameter_adapter_info()
+    if include_name:
+      self._cpp_impl_includes[include_name] = 1
+    emitter.Emit(
+        '\n'
+        '        const $ADAPTER_TYPE $NAME(Dart_GetNativeArgument(args, $INDEX));\n'
+        '        if (!$NAME.conversionSuccessful()) {\n'
+        '            exception = $NAME.exception();\n'
+        '            goto fail;\n'
+        '        }\n',
+        ADAPTER_TYPE=adapter_type,
+        NAME=idl_argument.id,
+        INDEX=index + 1)
+
+  def _GenerateNativeBinding(self, idl_name, argument_count, dart_declaration,
+      native_suffix, is_custom):
+    native_binding = '%s_%s_%s' % (self._interface.id, idl_name, native_suffix)
+    self._members_emitter.Emit(
+        '\n'
+        '  $DART_DECLARATION native "$NATIVE_BINDING";\n',
+        DART_DECLARATION=dart_declaration, NATIVE_BINDING=native_binding)
+
+    cpp_callback_name = '%s%s' % (idl_name, native_suffix)
+    self._cpp_resolver_emitter.Emit(
+        '    if (argumentCount == $ARGC && name == "$NATIVE_BINDING")\n'
+        '        return Dart$(INTERFACE_NAME)Internal::$CPP_CALLBACK_NAME;\n',
+        ARGC=argument_count,
+        NATIVE_BINDING=native_binding,
+        INTERFACE_NAME=self._interface.id,
+        CPP_CALLBACK_NAME=cpp_callback_name)
+
+    if is_custom:
+      self._cpp_declarations_emitter.Emit(
+          '\n'
+          'void $CPP_CALLBACK_NAME(Dart_NativeArguments);\n',
+          CPP_CALLBACK_NAME=cpp_callback_name)
+
+    return cpp_callback_name
+
+  def _GenerateWebCoreReflectionAttributeName(self, attr):
+    namespace = 'HTMLNames'
+    svg_exceptions = ['class', 'id', 'onabort', 'onclick', 'onerror', 'onload',
+                      'onmousedown', 'onmousemove', 'onmouseout', 'onmouseover',
+                      'onmouseup', 'onresize', 'onscroll', 'onunload']
+    if self._interface.id.startswith('SVG') and not attr.id in svg_exceptions:
+      namespace = 'SVGNames'
+    self._cpp_impl_includes[namespace] = 1
+
+    attribute_name = attr.ext_attrs['Reflect'] or attr.id.lower()
+    return 'WebCore::%s::%sAttr' % (namespace, attribute_name)