Issue 9390007: Move SpeechRecognizer delegate into its own header file and put it in the content namespace.

Issue 9390007: Move SpeechRecognizer delegate into its own header file and put it in the content namespace. (Closed)

Created:
8 years, 10 months ago by tfarina

Modified:
8 years, 10 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, Aaron Boodman, jam, mihaip+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move SpeechRecognizer delegate into its own header file and put it in the content namespace. This avoids having a nested class as it leads to too many includes in headers. BUG=98716 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121810

Patch Set 1 : #

Patch Set 2 : please win trybot #

Total comments: 2

Patch Set 3 : jam review - update interface comment #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -77 lines)			Patch
M	chrome/browser/speech/speech_input_extension_apitest.cc	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/speech/speech_input_extension_manager.h	View		5 chunks	+13 lines, -5 lines	0 comments	Download
M	chrome/browser/speech/speech_input_extension_manager.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/speech/speech_input_browsertest.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/speech/speech_input_manager.h	View		2 chunks	+12 lines, -3 lines	0 comments	Download
M	content/browser/speech/speech_input_manager.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/speech/speech_recognizer.h	View		6 chunks	+9 lines, -60 lines	0 comments	Download
M	content/browser/speech/speech_recognizer.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/speech/speech_recognizer_unittest.cc	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	content/content_browser.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	content/public/browser/speech_recognizer_delegate.h	View	1 2	1 chunk	+65 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm http://codereview.chromium.org/9390007/diff/3003/content/public/browser/speech_recognizer_delegate.h File content/public/browser/speech_recognizer_delegate.h (right): http://codereview.chromium.org/9390007/diff/3003/content/public/browser/speech_recognizer_delegate.h#newcode13 content/public/browser/speech_recognizer_delegate.h:13: // Implemented by the caller to receive recognition ...

8 years, 10 months ago (2012-02-13 17:42:12 UTC) #2

tfarina

8 years, 10 months ago (2012-02-13 18:44:17 UTC) #3

http://codereview.chromium.org/9390007/diff/3003/content/public/browser/speec...
File content/public/browser/speech_recognizer_delegate.h (right):

http://codereview.chromium.org/9390007/diff/3003/content/public/browser/speec...
content/public/browser/speech_recognizer_delegate.h:13: // Implemented by the
caller to receive recognition events.
On 2012/02/13 17:42:12, John Abd-El-Malek wrote:
> nit: this comment now needs more context, since |caller| doesn't mean anything
> here.

Done.

Expand Messages | Collapse Messages