Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: webkit/dom_storage/dom_storage_database_unittest.cc

Issue 9389009: Hook up DomStorageArea with a DomStorageDatabase. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments and delete databases on destruction if they are empty. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/dom_storage/dom_storage_database_unittest.cc
diff --git a/webkit/dom_storage/dom_storage_database_unittest.cc b/webkit/dom_storage/dom_storage_database_unittest.cc
index 3f2ec2630dcd54abbe7d4e6581158eaa3772ca12..585778225736fb0cc3d3c4c7308c9f6a625f55f2 100644
--- a/webkit/dom_storage/dom_storage_database_unittest.cc
+++ b/webkit/dom_storage/dom_storage_database_unittest.cc
@@ -113,6 +113,24 @@ TEST(DomStorageDatabaseTest, SimpleOpenAndClose) {
EXPECT_FALSE(db.IsOpen());
}
+TEST(DomStorageDatabaseTest, CloseEmptyDatabaseDeletesFile) {
+ ScopedTempDir temp_dir;
+ ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
+ FilePath file_name = temp_dir.path().AppendASCII("TestDomStorageDatabase.db");
+
+ {
+ DomStorageDatabase db(file_name);
+ ValuesMap storage;
+ CreateMapWithValues(&storage);
+
+ ASSERT_TRUE(db.CommitChanges(false, storage));
+ EXPECT_TRUE(file_util::PathExists(file_name));
+ storage.clear();
+ ASSERT_TRUE(db.CommitChanges(true, storage));
+ }
+ EXPECT_FALSE(file_util::PathExists(file_name));
+}
+
TEST(DomStorageDatabaseTest, TestLazyOpenIsLazy) {
// This test needs to operate with a file on disk to ensure that we will
// open a file that already exists when only invoking ReadAllValues.

Powered by Google App Engine
This is Rietveld 408576698