Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 9388002: Add support for Chrome Apps to IDL lexer/parser (Closed)

Created:
8 years, 10 months ago by asargent_no_longer_on_chrome
Modified:
8 years, 9 months ago
Reviewers:
noelallen1
CC:
chromium-reviews, miket_OOO
Visibility:
Public.

Description

This adds support for a number of features in the current WebIDL spec (http://dev.w3.org/2006/webapi/WebIDL/): -Callbacks -Dictionaries -static functions in interfaces -optional parameters and dictionary members It also introduces a "namespace" production to the grammar, which is just a named scope surrounding a list of other IDL fragments. Finally, there are a couple of random cleanups. BUG=116636 TEST=existing tests should still work Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124959

Patch Set 1 #

Patch Set 2 : fixed reduce conflicts and allowed use of callback as identifier #

Total comments: 6

Patch Set 3 : cleanup #

Patch Set 4 : removed apps_tests from this CL, will put them back in when we move generators to new location in t… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -30 lines) Patch
M ppapi/api/dev/pp_cursor_type_dev.idl View 1 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/generators/idl_lexer.py View 1 2 3 chunks +18 lines, -2 lines 0 comments Download
M ppapi/generators/idl_node.py View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M ppapi/generators/idl_option.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/generators/idl_parser.py View 1 2 8 chunks +93 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
noelallen1
http://codereview.chromium.org/9388002/diff/4005/ppapi/generators/idl_lexer.py File ppapi/generators/idl_lexer.py (right): http://codereview.chromium.org/9388002/diff/4005/ppapi/generators/idl_lexer.py#newcode135 ppapi/generators/idl_lexer.py:135: r'(/\*(.|\n)*?\*/)|(//.*(\n//.*)*)' Isn't this missing indentation/whitespace between the >>*(\n<< and ...
8 years, 9 months ago (2012-02-28 22:31:32 UTC) #1
asargent_no_longer_on_chrome
http://codereview.chromium.org/9388002/diff/4005/ppapi/generators/idl_lexer.py File ppapi/generators/idl_lexer.py (right): http://codereview.chromium.org/9388002/diff/4005/ppapi/generators/idl_lexer.py#newcode135 ppapi/generators/idl_lexer.py:135: r'(/\*(.|\n)*?\*/)|(//.*(\n//.*)*)' On 2012/02/28 22:31:33, noelallen1 wrote: > Isn't this ...
8 years, 9 months ago (2012-03-03 01:12:02 UTC) #2
noelallen1
lgtm
8 years, 9 months ago (2012-03-03 01:25:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/9388002/20001
8 years, 9 months ago (2012-03-03 03:57:33 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-03 03:57:40 UTC) #5
Presubmit check for 9388002-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Missing matching PPAPI definition:

***************
  ppapi/c/dev/pp_cursor_type_dev.h
***************

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
ppapi/apps_tests/test1.idl,ppapi/apps_tests/test3.idl,ppapi/apps_tests/experimental.socket.idl,ppapi/apps_tests/test2.idl

Presubmit checks took 2.0s to calculate.

Powered by Google App Engine
This is Rietveld 408576698