Fix unicode upgrade of patch.

Fix unicode upgrade of patch.

When a diff contains utf8 character, the filename would be stored as a unicode
object instead of a str. This is even if the buffer is originally sent as a
utf-8 encoded str. Then once the diff is reconstructed to be sent to 'patch', a
unicode object instead of a str would be sent, confusing patch.

R=cmp@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122361

[M-A Ruel, 2012-02-14 02:35:16]

This is what caused problems with
https://chromiumcodereview.appspot.com/9233057/ since the diff contained utf-8
characters. It's a bit sad to have to do that but at least with this CL it
should fix the problem.

[cmp, 2012-02-14 18:11:59]

https://chromiumcodereview.appspot.com/9387024/diff/1/tests/patch_test.py
File tests/patch_test.py (right):

https://chromiumcodereview.appspot.com/9387024/diff/1/tests/patch_test.py#new...
tests/patch_test.py:279: p = patch.FilePatchDiff(u'file_b', RAW.MINIMAL_RENAME,
[])
This string (u'file_b') can be both encoded and decoded through 'utf-8'.  I
think a better test would be a unicode string that contains a unicode character
(like '\ua000') which can only be utf-8 encoded (u'\ua000' cannot be utf-8
decoded).  WDYT?

[M-A Ruel, 2012-02-14 22:03:59]

see new patch.

[Marc-Antoine Ruel (Google), 2012-02-16 01:41:09]

On 2012/02/14 22:03:59, Marc-Antoine Ruel wrote:
> see new patch.

ping

[M-A Ruel, 2012-02-16 18:03:53]

TBR'ing since this bug is really bad.

[cmp, 2012-02-16 19:07:38]

lgtm

Thanks for updating the tests.

[commit-bot: I haz the power, 2012-02-16 21:44:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9387024/2002

[commit-bot: I haz the power, 2012-02-16 21:50:36]

Change committed as 122361