Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/extensions/chrome_v8_extension_handler.h

Issue 9386001: Implement a module system for the extension bindings JS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: base files missing? Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/chrome_v8_extension.cc ('k') | chrome/renderer/extensions/context_menus_custom_bindings.h » ('j') | chrome/renderer/resources/extensions/apitest.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/chrome_v8_extension_handler.h
diff --git a/chrome/renderer/extensions/chrome_v8_extension_handler.h b/chrome/renderer/extensions/chrome_v8_extension_handler.h
index edeb5187395f1cab6f9093b5dd55fc9856a0d2b1..fdf9b05b1198b0a9d28f9fb5d0f5e5276457bfc4 100644
--- a/chrome/renderer/extensions/chrome_v8_extension_handler.h
+++ b/chrome/renderer/extensions/chrome_v8_extension_handler.h
@@ -15,11 +15,10 @@
class ChromeV8Context;
// Base class for context-scoped handlers used with ChromeV8Extension.
+// TODO(koz): Rename/refactor this somehow. Maybe just pull it into
+// ChromeV8Extension.
class ChromeV8ExtensionHandler : public IPC::Channel::Listener {
public:
- virtual v8::Handle<v8::Value> HandleNativeFunction(
- const std::string& name,
- const v8::Arguments& arguments) = 0;
virtual ~ChromeV8ExtensionHandler();
// IPC::Channel::Listener
« no previous file with comments | « chrome/renderer/extensions/chrome_v8_extension.cc ('k') | chrome/renderer/extensions/context_menus_custom_bindings.h » ('j') | chrome/renderer/resources/extensions/apitest.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698