Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: runtime/vm/code_generator_x64.cc

Issue 9385022: Add PC descriptor for ret instruction (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/code_generator_x64.cc
===================================================================
--- runtime/vm/code_generator_x64.cc (revision 4139)
+++ runtime/vm/code_generator_x64.cc (working copy)
@@ -756,7 +756,7 @@
}
-void CodeGenerator::GenerateReturnEpilog() {
+void CodeGenerator::GenerateReturnEpilog(ReturnNode* node) {
// Unchain the context(s) up to context level 0.
int context_level = state()->context_level();
ASSERT(context_level >= 0);
@@ -787,6 +787,8 @@
}
__ LeaveFrame();
__ ret();
+ // TODO(hausner): insert generation of of PcDescriptor::kReturn,
+ // analogous to 32bit version.
#ifdef DEBUG
__ Bind(&wrong_stack);
@@ -836,7 +838,7 @@
String::ZoneHandle(String::NewSymbol("function result")));
}
}
- GenerateReturnEpilog();
+ GenerateReturnEpilog(node);
}

Powered by Google App Engine
This is Rietveld 408576698