Issue 9385017: git-cl: split GetRietveldServer from GetIssue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9385017: git-cl: split GetRietveldServer from GetIssue (Closed)

Created:
8 years, 10 months ago by Evan Martin

Modified:
8 years, 10 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

git-cl: split GetRietveldServer from GetIssue Should be no functional change. Necessary for a follow-up change I'm making. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121590

Patch Set 2 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	git_cl.py	View	1	2 chunks	+10 lines, -7 lines	0 comments	Download
	M	tests/git_cl_test.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm https://chromiumcodereview.appspot.com/9385017/diff/1/git_cl.py File git_cl.py (right): https://chromiumcodereview.appspot.com/9385017/diff/1/git_cl.py#newcode571 git_cl.py:571: self._rpc_server = rietveld.Rietveld(self.rietveld_server, None, None) self._rpc_server = rietveld.Rietveld(self.GetRietveldServer(), ...

8 years, 10 months ago (2012-02-11 00:31:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/evan@chromium.org/9385017/3002

8 years, 10 months ago (2012-02-11 00:35:24 UTC) #4

Change committed as 121590

Expand Messages | Collapse Messages

Issue 9385017: git-cl: split GetRietveldServer from GetIssue (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages