webkit/tools/test_shell/test_shell_devtools_agent.cc - Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/tools/test_shell/test_shell_devtools_agent.cc

Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename back to "allow". Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/tools/test_shell/test_shell_devtools_agent.cc

diff --git a/webkit/tools/test_shell/test_shell_devtools_agent.cc b/webkit/tools/test_shell/test_shell_devtools_agent.cc

index b2e4a953e8a380709c77660f69f2ca8b0e4a4b39..895e36206bc364b3025a8d140683c4663164d551 100644

--- a/webkit/tools/test_shell/test_shell_devtools_agent.cc

+++ b/webkit/tools/test_shell/test_shell_devtools_agent.cc

@@ -29,10 +29,8 @@ class WebKitClientMessageLoopImpl

message_loop_ = NULL;

}

virtual void run() {

- bool old_state = message_loop_->NestableTasksAllowed();

- message_loop_->SetNestableTasksAllowed(true);

+ MessageLoop::ScopedNestableTaskAllower allow(message_loop_);

message_loop_->Run();

- message_loop_->SetNestableTasksAllowed(old_state);

}

virtual void quitNow() {

message_loop_->QuitNow();

« no previous file with comments | « webkit/support/webkit_support.cc ('k') | no next file » | no next file with comments »