webkit/plugins/ppapi/ppb_flash_impl.cc - Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppb_flash_impl.cc

Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename back to "allow". Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/ppapi/ppb_flash_impl.cc

diff --git a/webkit/plugins/ppapi/ppb_flash_impl.cc b/webkit/plugins/ppapi/ppb_flash_impl.cc

index c1133ba6d3be5aac012ecb4127b88ddd988517fc..2dc7842b5280b7fab56715ee66f2351c8c7a6611 100644

--- a/webkit/plugins/ppapi/ppb_flash_impl.cc

+++ b/webkit/plugins/ppapi/ppb_flash_impl.cc

@@ -199,10 +199,8 @@ int32_t Navigate11(PP_Resource request_id,

}

void RunMessageLoop(PP_Instance instance) {

- bool old_state = MessageLoop::current()->NestableTasksAllowed();

- MessageLoop::current()->SetNestableTasksAllowed(true);

+ MessageLoop::ScopedNestableTaskAllower allow(MessageLoop::current());

MessageLoop::current()->Run();

- MessageLoop::current()->SetNestableTasksAllowed(old_state);

}

void QuitMessageLoop(PP_Instance instance) {