ui/views/controls/menu/menu_controller.cc - Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_controller.cc

Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename back to "allow". Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_controller.cc

diff --git a/ui/views/controls/menu/menu_controller.cc b/ui/views/controls/menu/menu_controller.cc

index 873fcf52ef6cd342b0b73004d92e48b576faa298..73149c28bcad8d2a3aef5ee6eb69d7107dc3a692 100644

--- a/ui/views/controls/menu/menu_controller.cc

+++ b/ui/views/controls/menu/menu_controller.cc

@@ -323,11 +323,11 @@ MenuItemView* MenuController::Run(Widget* parent,

aura::client::GetDispatcherClient()->RunWithDispatcher(this,

parent->GetNativeWindow(), true);

#else

- MessageLoopForUI* loop = MessageLoopForUI::current();

- bool did_allow_task_nesting = loop->NestableTasksAllowed();

- loop->SetNestableTasksAllowed(true);

- loop->RunWithDispatcher(this);

- loop->SetNestableTasksAllowed(did_allow_task_nesting);

+ {

+ MessageLoopForUI* loop = MessageLoopForUI::current();

+ MessageLoop::ScopedNestableTaskAllower allow(loop);

+ loop->RunWithDispatcher(this);

+ }

#endif

if (ViewsDelegate::views_delegate)

« no previous file with comments | « ppapi/proxy/ppb_testing_proxy.cc ('k') | webkit/database/database_connections.cc » ('j') | no next file with comments »