ipc/ipc_sync_channel.cc - Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_sync_channel.cc

Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename back to "allow". Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_sync_channel.cc

diff --git a/ipc/ipc_sync_channel.cc b/ipc/ipc_sync_channel.cc

index 74d9744b17c14c8a6e794d974f24f3feba0bd093..be8315cdcda8cbf39db265e89559df3eae5dbc85 100644

--- a/ipc/ipc_sync_channel.cc

+++ b/ipc/ipc_sync_channel.cc

@@ -506,11 +506,11 @@ void SyncChannel::WaitForReplyWithNestedMessageLoop(SyncContext* context) {

sync_msg_queue->set_top_send_done_watcher(&send_done_watcher);

send_done_watcher.StartWatching(context->GetSendDoneEvent(), context);

- bool old_state = MessageLoop::current()->NestableTasksAllowed();

- MessageLoop::current()->SetNestableTasksAllowed(true);

- MessageLoop::current()->Run();

- MessageLoop::current()->SetNestableTasksAllowed(old_state);

+ {

+ MessageLoop::ScopedNestableTaskAllower allow(MessageLoop::current());

+ MessageLoop::current()->Run();

+ }

sync_msg_queue->set_top_send_done_watcher(old_send_done_event_watcher);

if (old_send_done_event_watcher && old_event) {

« no previous file with comments | « content/renderer/devtools_agent.cc ('k') | net/base/file_stream_unittest.cc » ('j') | no next file with comments »