chrome/test/base/ui_test_utils.cc - Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/ui_test_utils.cc

Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename back to "allow". Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/ui_test_utils.cc

diff --git a/chrome/test/base/ui_test_utils.cc b/chrome/test/base/ui_test_utils.cc

index dc6876460af634751ca0e9fd55d8414fefa877c4..6a580d79e8a6d497ebc92ebcd8689cd2214ee501 100644

--- a/chrome/test/base/ui_test_utils.cc

+++ b/chrome/test/base/ui_test_utils.cc

@@ -266,8 +266,7 @@ void RunMessageLoop() {

MessageLoopForUI* ui_loop =

content::BrowserThread::CurrentlyOn(content::BrowserThread::UI) ?

MessageLoopForUI::current() : NULL;

- bool did_allow_task_nesting = loop->NestableTasksAllowed();

- loop->SetNestableTasksAllowed(true);

+ MessageLoop::ScopedNestableTaskAllower allow(loop);

if (ui_loop) {

#if defined(USE_AURA)

aura::RootWindow::GetInstance()->Run();

@@ -282,7 +281,6 @@ void RunMessageLoop() {

} else {

loop->Run();

}

- loop->SetNestableTasksAllowed(did_allow_task_nesting);

}

void RunAllPendingInMessageLoop() {