chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc - Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc

Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename back to "allow". Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc

diff --git a/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc b/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc

index 4325e40d7c4697c11bd992b6ba4b49a6465b89f0..45dde04a732d961e9faa1d5970e4167dbd564aca 100644

--- a/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc

+++ b/chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc

@@ -362,10 +362,8 @@ void TabContentsViewViews::ShowContextMenu(

// Enable recursive tasks on the message loop so we can get updates while

// the context menu is being displayed.

- bool old_state = MessageLoop::current()->NestableTasksAllowed();

- MessageLoop::current()->SetNestableTasksAllowed(true);

+ MessageLoop::ScopedNestableTaskAllower allow(MessageLoop::current());

context_menu_->RunMenuAt(screen_point.x(), screen_point.y());

- MessageLoop::current()->SetNestableTasksAllowed(old_state);

}

void TabContentsViewViews::ShowPopupMenu(const gfx::Rect& bounds,