chrome/browser/ui/views/simple_message_box_views.cc - Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/simple_message_box_views.cc

Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename back to "allow". Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/simple_message_box_views.cc

diff --git a/chrome/browser/ui/views/simple_message_box_views.cc b/chrome/browser/ui/views/simple_message_box_views.cc

index c644a4e32c462449c9f3c592f863f9ab6b571aa6..596b7d9f8bed33164b56777aec9fe5e33d8d4a5f 100644

--- a/chrome/browser/ui/views/simple_message_box_views.cc

+++ b/chrome/browser/ui/views/simple_message_box_views.cc

@@ -63,10 +63,10 @@ bool SimpleMessageBoxViews::ShowYesNoBox(gfx::NativeWindow parent_window,

aura::client::GetDispatcherClient()->RunWithDispatcher(dialog,

parent_window, true);

#else

- bool old_state = MessageLoopForUI::current()->NestableTasksAllowed();

- MessageLoopForUI::current()->SetNestableTasksAllowed(true);

- MessageLoopForUI::current()->RunWithDispatcher(dialog);

- MessageLoopForUI::current()->SetNestableTasksAllowed(old_state);

+ {

+ MessageLoop::ScopedNestableTaskAllower allow(MessageLoopForUI::current());

+ MessageLoopForUI::current()->RunWithDispatcher(dialog);

+ }

#endif

g_browser_process->ReleaseModule();