chrome/browser/printing/print_view_manager.cc - Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_view_manager.cc

Issue 9384024: Prefer ScopedNestableTaskAllower over manual save/restore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rename back to "allow". Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_view_manager.cc

diff --git a/chrome/browser/printing/print_view_manager.cc b/chrome/browser/printing/print_view_manager.cc

index 3a5bdd6174a72f31da3ab7d5eedb70bd943123e8..32403c2a3a8659949fd93686952ae76ca8ae3fe5 100644

--- a/chrome/browser/printing/print_view_manager.cc

+++ b/chrome/browser/printing/print_view_manager.cc

@@ -556,11 +556,10 @@ bool PrintViewManager::RunInnerMessageLoop() {

inside_inner_message_loop_ = true;

// Need to enable recursive task.

- bool old_state = MessageLoop::current()->NestableTasksAllowed();

- MessageLoop::current()->SetNestableTasksAllowed(true);

- MessageLoop::current()->Run();

- // Restore task state.

- MessageLoop::current()->SetNestableTasksAllowed(old_state);

+ {

+ MessageLoop::ScopedNestableTaskAllower allow(MessageLoop::current());

+ MessageLoop::current()->Run();

+ }

bool success = true;

if (inside_inner_message_loop_) {

« no previous file with comments | « chrome/browser/printing/print_job.cc ('k') | chrome/browser/sessions/session_restore.cc » ('j') | no next file with comments »