Prefer ScopedNestableTaskAllower over manual save/restore

net/socket/transport_client_socket_pool_unittest.cc

Index: net/socket/transport_client_socket_pool_unittest.cc
diff --git a/net/socket/transport_client_socket_pool_unittest.cc b/net/socket/transport_client_socket_pool_unittest.cc
index 301251890252e5f04358d94eac05653976f817cc..3aeda509fff9cd1e92eef1ebd7d1600398d3f290 100644
--- a/net/socket/transport_client_socket_pool_unittest.cc
+++ b/net/socket/transport_client_socket_pool_unittest.cc
@@ -797,8 +797,7 @@ class RequestSocketCallback : public TestCompletionCallbackBase {
       handle_->socket()->Disconnect();
       handle_->Reset();
       {
-        MessageLoop::ScopedNestableTaskAllower nestable(
-            MessageLoop::current());
+        MessageLoop::ScopedNestableTaskAllower allow(MessageLoop::current());
         MessageLoop::current()->RunAllPending();
       }
       within_callback_ = true;

[jar (doing other things), 2012/02/11 03:24:38]

again... this looks like a pattern to prevent recursion (re: line 794 and line
803), but we potentially recurse via lines 801.

If we really wanted to prevent recursion, wouldn't we have set line 803 before
we did the RunAllPending()?

Looking at the code some more, I see that within_callback_ is seemingly only set
to true, and never reset to false.  Does this mean a better name would have been
ran_callback_?