base/android/jni_generator/jni_generator.gyp - Issue 9384011: Chrome on Android: adds jni_generator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/android/jni_generator/jni_generator.gyp

Issue 9384011: Chrome on Android: adds jni_generator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Joth's comments Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« base/android/jni_generator/SampleForTests.java ('K') | « base/android/jni_generator/golden_sample_for_tests_jni.h ('k') | base/android/jni_generator/jni_generator.py » ('j') | base/android/jni_generator/jni_generator.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 {
	Mark Mentovai 2012/02/14 20:00:38 It’s usual to put a blank line before this { to se It’s usual to put a blank line before this { to separate it from the boilerplate. bulach 2012/02/14 23:18:11 Done. Show quoted text On 2012/02/14 20:00:38, Mark Mentovai wrote: > It’s usual to put a blank line before this { to separate it from the > boilerplate. Done.
	5 'targets': [

	6 {

	7 'target_name': 'jni_generator_py_tests',

	8 'type': 'none',

	9 'actions': [

	10 {

	11 'action_name': 'run_jni_generator_py_tests',

	12 'inputs': [

	13 'jni_generator.py',

	14 'jni_generator_tests.py',

	15 'SampleForTests.java',

	16 'golden_sample_for_tests_jni.h',

	17 ],

	18 'outputs': [

	19 '',
	Mark Mentovai 2012/02/14 20:00:38 Really? No outputs? Really? No outputs? bulach 2012/02/14 23:18:11 this action is just to run the python tests, it do Show quoted text On 2012/02/14 20:00:38, Mark Mentovai wrote: > Really? No outputs? this action is just to run the python tests, it doesn't produce any output..
	20 ],

	21 'action': [

	22 'python', './jni_generator_tests.py',
	Mark Mentovai 2012/02/14 20:00:38 You don’t need the ./ here. You don’t need the ./ here. bulach 2012/02/14 23:18:11 Done. Show quoted text On 2012/02/14 20:00:38, Mark Mentovai wrote: > You don’t need the ./ here. Done.
	23 ],

	24 },

	25 ],

	26 },

	27 {

	28 'target_name': 'jni_sample_header',

	29 'type': 'none',

	30 'actions': [

	31 {

	32 'action_name': 'generate_jni_sample_header',

	33 'inputs': [

	34 'jni_generator.py',

	35 'SampleForTests.java',

	36 ],

	37 'outputs': [

	38 '<(SHARED_INTERMEDIATE_DIR)/base/jni/sample_for_tests_jni.h',

	39 ],

	40 'action': [

	41 'python',

	42 'jni_generator.py',

	43 '-o',

	44 '<@(_inputs)',

	45 '<@(_outputs)',

	46 ],

	47 },

	48 ],

	49 },

	50 {

	51 'target_name': 'jni_generator_tests',

	52 'type': 'executable',

	53 'dependencies': [

	54 '../../base.gyp:test_support_base',

	55 'jni_generator_py_tests',

	56 'jni_sample_header',

	57 ],

	58 'include_dirs': [

	59 '<(SHARED_INTERMEDIATE_DIR)/base',

	60 ],

	61 'sources': [

	62 'sample_for_tests.cc',

	63 ],

	64 },

	65 ],

	66 }

OLD	NEW