chrome/browser/extensions/extension_menu_manager.h - Issue 9382037: Move ContextMenuParams struct from webkit/glue to content/public/common. The reasons are:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_menu_manager.h

Issue 9382037: Move ContextMenuParams struct from webkit/glue to content/public/common. The reasons are: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix mac Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_browsertest.cc ('k') | chrome/browser/extensions/extension_menu_manager.cc » ('j') | content/public/common/context_menu_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_menu_manager.h

===================================================================

--- chrome/browser/extensions/extension_menu_manager.h (revision 121660)

+++ chrome/browser/extensions/extension_menu_manager.h (working copy)

@@ -21,7 +21,6 @@

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

-struct ContextMenuParams;

class Extension;

class Profile;

@@ -29,6 +28,7 @@

namespace content {

class WebContents;

+struct ContextMenuParams;

}

// Represents a menu item added by an extension.

@@ -247,7 +247,7 @@

// Called when a menu item is clicked on by the user.

void ExecuteCommand(Profile* profile, content::WebContents* web_contents,

- const ContextMenuParams& params,

+ const content::ContextMenuParams& params,

const ExtensionMenuItem::Id& menuItemId);

// This returns a bitmap of width/height kFaviconSize, loaded either from an