Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: ppapi/cpp/var.h

Issue 9381010: Convert resources to take an instance key instead of an Instance*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: USELESS PATCH TITLE Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/cpp/url_response_info.cc ('k') | ppapi/cpp/websocket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/var.h
diff --git a/ppapi/cpp/var.h b/ppapi/cpp/var.h
index a0c5c19f281e6c797bc91336cf442802ff58cf4f..b0914be3de7f473c81cf76571ab9edce6d9f199e 100644
--- a/ppapi/cpp/var.h
+++ b/ppapi/cpp/var.h
@@ -9,7 +9,7 @@
#include <vector>
#include "ppapi/c/pp_var.h"
-
+#include "ppapi/cpp/pass_ref.h"
/// @file
/// This file defines the API for handling the passing of data types between
@@ -50,12 +50,6 @@ class Var {
/// A constructor used to create a UTF-8 character <code>Var</code>.
Var(const std::string& utf8_str); // Must be encoded in UTF-8.
- /// PassRef can be used to construct a <code>Var</code> with a
- /// <code>PP_Var</code> when the <code>PP_Var</code>
- /// already has had its reference count incremented. For example:
- /// <code>pp::Var my_var(PassRef(), my_pp_var);</code>
- struct PassRef {};
-
/// A constructor used when you have received a <code>Var</code> as a return
/// value that has had its reference count incremented for you.
///
@@ -269,7 +263,7 @@ class Var {
/// Destructor.
~OutException() {
if (output_ && !originally_had_exception_)
- *output_ = Var(PassRef(), temp_);
+ *output_ = Var(PASS_REF, temp_);
}
PP_Var* get() {
« no previous file with comments | « ppapi/cpp/url_response_info.cc ('k') | ppapi/cpp/websocket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698