Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: ppapi/cpp/url_loader.h

Issue 9381010: Convert resources to take an instance key instead of an Instance*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: USELESS PATCH TITLE Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/cpp/trusted/file_chooser_trusted.cc ('k') | ppapi/cpp/url_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/url_loader.h
diff --git a/ppapi/cpp/url_loader.h b/ppapi/cpp/url_loader.h
index 6074cb9bebd50c97abbf089970a63714f6a92b53..3ed5fe6e9255109ce323ef70b8a9bcce46f83846 100644
--- a/ppapi/cpp/url_loader.h
+++ b/ppapi/cpp/url_loader.h
@@ -13,7 +13,7 @@
namespace pp {
class CompletionCallback;
-class Instance;
+class InstanceHandle;
class URLRequestInfo;
class URLResponseInfo;
@@ -26,10 +26,6 @@ class URLLoader : public Resource {
/// <code>URLLoader</code> object.
URLLoader() {}
- // TODO(brettw) remove this when NaCl is updated to use the new version
- // that takes a pointer.
- explicit URLLoader(const Instance& instance);
-
/// A constructor used when a <code>PP_Resource</code> is provided as a
/// return value whose reference count we need to increment.
///
@@ -40,8 +36,9 @@ class URLLoader : public Resource {
/// A constructor used to allocate a new URLLoader in the browser. The
/// resulting object will be <code>is_null</code> if the allocation failed.
///
- /// @param[in] instance An <code>Instance</code>.
- explicit URLLoader(Instance* instance);
+ /// @param[in] instance The instance with which this resource will be
+ /// associated.
+ explicit URLLoader(const InstanceHandle& instance);
/// The copy constructor for <code>URLLoader</code>.
///
« no previous file with comments | « ppapi/cpp/trusted/file_chooser_trusted.cc ('k') | ppapi/cpp/url_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698