Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: ppapi/cpp/audio_config.h

Issue 9381010: Convert resources to take an instance key instead of an Instance*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: USELESS PATCH TITLE Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/cpp/audio.cc ('k') | ppapi/cpp/audio_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/audio_config.h
diff --git a/ppapi/cpp/audio_config.h b/ppapi/cpp/audio_config.h
index ff1d25648c07e666849d3f492aaf903f7ae2246b..e8c47ab12167968808adcb9f7a02abc4cc0b9c8b 100644
--- a/ppapi/cpp/audio_config.h
+++ b/ppapi/cpp/audio_config.h
@@ -16,7 +16,7 @@
namespace pp {
-class Instance;
+class InstanceHandle;
/// A 16 bit stereo AudioConfig resource. Refer to the
/// <a href="/chrome/nativeclient/docs/audio.html">Pepper
@@ -64,21 +64,24 @@ class AudioConfig : public Resource {
/// resulting resource will be is_null(). You can pass the result of
/// RecommendSampleFrameCount() as the sample frame count.
///
- /// @param[in] instance A pointer to an <code>Instance</code> identifying
- /// one instance of a module.
+ /// @param[in] instance The instance with which this resource will be
+ /// associated.
+ ///
/// @param[in] sample_rate A <code>PP_AudioSampleRate</code> which is either
/// <code>PP_AUDIOSAMPLERATE_44100</code> or
/// <code>PP_AUDIOSAMPLERATE_48000</code>.
+ ///
/// @param[in] sample_frame_count A uint32_t frame count returned from the
/// <code>RecommendSampleFrameCount</code> function.
- AudioConfig(Instance* instance,
+ AudioConfig(const InstanceHandle& instance,
PP_AudioSampleRate sample_rate,
uint32_t sample_frame_count);
/// RecommendSampleRate() returns the native sample rate used by the
/// audio system. Applications that use the recommended sample rate might
/// obtain lower latency and higher fidelity output.
- static PP_AudioSampleRate RecommendSampleRate(Instance* instance);
+ static PP_AudioSampleRate RecommendSampleRate(
+ const InstanceHandle& instance);
/// RecommendSampleFrameCount() returns a supported frame count closest to
/// the requested count. The sample frame count determines the overall
@@ -92,8 +95,6 @@ class AudioConfig : public Resource {
/// will return a supported count closest to the requested value for use in
/// the constructor.
///
- /// @param[in] instance A pointer to an <code>Instance</code> identifying
- /// one instance of a module.
/// @param[in] sample_rate A <code>PP_AudioSampleRate</code> which is either
/// <code>PP_AUDIOSAMPLERATE_44100</code> or
/// <code>PP_AUDIOSAMPLERATE_48000</code>.
@@ -103,7 +104,7 @@ class AudioConfig : public Resource {
/// successful. If the sample frame count or bit rate is not supported,
/// this function will fail and return 0.
static uint32_t RecommendSampleFrameCount(
- Instance* instance,
+ const InstanceHandle& instance,
PP_AudioSampleRate sample_rate,
uint32_t requested_sample_frame_count);
« no previous file with comments | « ppapi/cpp/audio.cc ('k') | ppapi/cpp/audio_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698