Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 9381006: MIPS: Split AST Declaration class, in preparation for new module declaration forms. (Closed)

Created:
8 years, 10 months ago by kalmard
Modified:
8 years, 10 months ago
Reviewers:
kisg, Paul Lind, rossberg, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Split AST Declaration class, in preparation for new module declaration forms. Port r10662 (c8054f6). Original commit message: Turns Declaration into an abstract class, and introduces VariableDeclaration as a concrete subclass. BUG= TEST=

Patch Set 1 #

Patch Set 2 : rebased on r10702 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/mips/full-codegen-mips.cc View 1 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kalmard
8 years, 10 months ago (2012-02-10 14:46:12 UTC) #1
kalmard
rebased on r10702
8 years, 10 months ago (2012-02-14 15:14:19 UTC) #2
rossberg
lgtm
8 years, 10 months ago (2012-02-14 15:54:39 UTC) #3
rossberg
Landed as http://codereview.chromium.org/9395015/
8 years, 10 months ago (2012-02-14 16:14:14 UTC) #4
kalmard
8 years, 10 months ago (2012-02-16 12:30:49 UTC) #5
Thanks for landing.
Closing.

Powered by Google App Engine
This is Rietveld 408576698