Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 9380039: Add IconFamily library to third_party (Closed)

Created:
8 years, 10 months ago by sail
Modified:
8 years, 10 months ago
Reviewers:
Robert Sesek, open-source-third-party-reviews, Nico, jeremy, Daniel Berlin
CC:
chromium-reviews, dmac
Visibility:
Public.

Description

Add IconFamily library to third_party This library will be used by the platform apps feature on the Mac to save .icns files. BUG=112651 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2035 lines, -0 lines) Patch
A third_party/icon_family/IconFamily.h View 1 chunk +190 lines, -0 lines 0 comments Download
A third_party/icon_family/IconFamily.m View 1 chunk +1714 lines, -0 lines 0 comments Download
A third_party/icon_family/LICENSE View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/icon_family/NSString+CarbonFSRefCreation.h View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/icon_family/NSString+CarbonFSRefCreation.m View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/icon_family/README.chromium View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/icon_family/icon_family.gyp View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sail
This is a unmodified copy of IconFamily from trunk: http://iconfamily.svn.sourceforge.net/viewvc/iconfamily/trunk/ I'm sending my local modifications ...
8 years, 10 months ago (2012-02-11 02:42:39 UTC) #1
sail
+open-source-third-party-reviews@google.com requesting approval to add new third party library
8 years, 10 months ago (2012-02-11 02:45:02 UTC) #2
Nico
+erg, dmac, since they contributed to the library. LGTM
8 years, 10 months ago (2012-02-11 02:52:55 UTC) #3
Daniel Berlin
LGTM This looks fine, just make sure the license it ends up in the chrome://credits ...
8 years, 10 months ago (2012-02-11 03:22:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/9380039/1
8 years, 10 months ago (2012-02-11 03:34:51 UTC) #5
commit-bot: I haz the power
Change committed as 121640
8 years, 10 months ago (2012-02-11 05:04:48 UTC) #6
Elliot Glaysher
8 years, 10 months ago (2012-02-13 20:17:01 UTC) #7
On 2012/02/11 02:52:55, Nico wrote:
> +erg, dmac, since they contributed to the library.

Everything old is new again.

Powered by Google App Engine
This is Rietveld 408576698