Add a stackframe named 'CrashIntentionally' to crashes from about:crash.

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 8240f49de3b66596a0ec355c47159fbed7828e8f..f4af5933df7673f9cfdcb8e6b77f8acbe189f52a 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -325,18 +325,18 @@ static WebReferrerPolicy getReferrerPolicyFromRequest(
       WebKit::WebReferrerPolicyDefault;
 }
 
+NOINLINE static void CrashIntentionally() {

[Nico, 2012/02/10 22:54:57]

http://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html#Attribute-Syntax :

"""An attribute specifier list may appear immediately before a declarator (other
than the first) in a comma-separated list of declarators in a declaration of
more than one identifier using a single list of specifiers and qualifiers. Such
attribute specifiers apply only to the identifier before whose declarator they
appear. For example, in

     __attribute__((noreturn)) void d0 (void),
         __attribute__((format(printf, 1, 2))) d1 (const char *, ...),
          d2 (void)
the noreturn attribute applies to all the functions declared; the format
attribute only applies to d1."""

Sounds like putting this in the front is explicitly supported, cool.

+  // NOTE(shess): Crash directly rather than using NOTREACHED() so
+  // that the signature is easier to triage in crash reports.
+  volatile int* zero = NULL;
+  *zero = 0;
+}
+
 static void MaybeHandleDebugURL(const GURL& url) {
   if (!url.SchemeIs(chrome::kChromeUIScheme))
     return;
   if (url == GURL(chrome::kChromeUICrashURL)) {
-    // NOTE(shess): Crash directly rather than using NOTREACHED() so
-    // that the signature is easier to triage in crash reports.
-    volatile int* zero = NULL;
-    *zero = 0;
-
-    // Just in case the compiler decides the above is undefined and
-    // optimizes it away.
-    NOTREACHED();
+    CrashIntentionally();
   } else if (url == GURL(chrome::kChromeUIKillURL)) {
     base::KillProcess(base::GetCurrentProcessHandle(), 1, false);
   } else if (url == GURL(chrome::kChromeUIHangURL)) {