Add a stackframe named 'CrashIntentionally' to crashes from about:crash.

Add a stackframe named 'CrashIntentionally' to crashes from about:crash.

This should make it easier to categorize on the crash server.

BUG=113231
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121798

[Nico, 2012-02-10 22:20:39]

https://chromiumcodereview.appspot.com/9380026/diff/1/content/renderer/render...
File content/renderer/render_view_impl.cc (right):

https://chromiumcodereview.appspot.com/9380026/diff/1/content/renderer/render...
content/renderer/render_view_impl.cc:337: __attribute__((noinline))
Does this work? I thought attributes go behind the function, like so:

  static void CrashIntentionall() __attribute__((noinline))

[eroman, 2012-02-10 22:39:56]

I have updated to something simpler, PTAL.

@thakis: attributes seem fine at the start. By putting it at the start allows
dropping in the equivalent MSVC property in the macro, which by contrast does
NOT work at the end.

[jam, 2012-02-10 22:45:41]

I'm curious how we ignored these before I moved the code?

[eroman, 2012-02-10 22:47:00]

These were never ignored; the crash triagers just knew to recognize the other
callstack.

[jam, 2012-02-10 22:51:00]

On 2012/02/10 22:47:00, eroman wrote:
> These were never ignored; the crash triagers just knew to recognize the other
> callstack.

i see, lgtm

[Nico, 2012-02-10 22:54:57]

lgtm if it builds

https://chromiumcodereview.appspot.com/9380026/diff/5/base/compiler_specific.h
File base/compiler_specific.h (right):

https://chromiumcodereview.appspot.com/9380026/diff/5/base/compiler_specific....
base/compiler_specific.h:99: //   NOINLINE void DoStuff() { ... }
Hm, this seems not general enough for me to belong here – we don't want to use
this often. (But I'm not a base reviewer.)

https://chromiumcodereview.appspot.com/9380026/diff/5/content/renderer/render...
File content/renderer/render_view_impl.cc (right):

https://chromiumcodereview.appspot.com/9380026/diff/5/content/renderer/render...
content/renderer/render_view_impl.cc:328: NOINLINE static void
CrashIntentionally() {
http://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html#Attribute-Syntax :

"""An attribute specifier list may appear immediately before a declarator (other
than the first) in a comma-separated list of declarators in a declaration of
more than one identifier using a single list of specifiers and qualifiers. Such
attribute specifiers apply only to the identifier before whose declarator they
appear. For example, in

     __attribute__((noreturn)) void d0 (void),
         __attribute__((format(printf, 1, 2))) d1 (const char *, ...),
          d2 (void)
the noreturn attribute applies to all the functions declared; the format
attribute only applies to d1."""

Sounds like putting this in the front is explicitly supported, cool.

[eroman, 2012-02-10 23:06:00]

https://chromiumcodereview.appspot.com/9380026/diff/5/base/compiler_specific.h
File base/compiler_specific.h (right):

https://chromiumcodereview.appspot.com/9380026/diff/5/base/compiler_specific....
base/compiler_specific.h:99: //   NOINLINE void DoStuff() { ... }
On 2012/02/10 22:54:57, Nico wrote:
> Hm, this seems not general enough for me to belong here – we don't want to use
> this often. (But I'm not a base reviewer.)

To be clear this was already present in base, I am simply expanding it to be
defined for MSVC as well.

[eroman, 2012-02-10 23:06:20]

Adding Brett as reviewer for base/

[brettw, 2012-02-12 05:24:51]

base LGTM

[commit-bot: I haz the power, 2012-02-13 23:00:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/9380026/5

[commit-bot: I haz the power, 2012-02-14 01:12:16]

Change committed as 121798