Tweaks for improving file manager performance

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 const EMPTY_IMAGE_URI = 'data:image/gif;base64,'
         + 'R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw%3D%3D';
 
 /**
@@ skipping 462 matching lines @@
       };
     }
 
     // Optional list of file types.
     this.fileTypes_ = this.params_.typeList;
 
     this.showCheckboxes_ =
         (this.dialogType_ == FileManager.DialogType.FULL_PAGE ||
          this.dialogType_ == FileManager.DialogType.SELECT_OPEN_MULTI_FILE);
 
-    this.table_.list.startBatchUpdates();
+    this.table_.startBatchUpdates();
     this.grid_.startBatchUpdates();
 
     this.initFileList_();
     this.initDialogs_();
 
     this.copyManager_ = new FileCopyManager();
     this.copyManager_.addEventListener('copy-progress',
                                        this.onCopyProgress_.bind(this));
 
     window.addEventListener('popstate', this.onPopState_.bind(this));
@@ skipping 19 matching lines @@
     // The list of archives requested to mount. We will show contents once
     // archive is mounted, but only for mounts from within this filebrowser tab.
     this.mountRequests_ = [];
     this.unmountRequests_ = [];
     chrome.fileBrowserPrivate.onMountCompleted.addListener(
         this.onMountCompleted_.bind(this));
 
     chrome.fileBrowserPrivate.onFileChanged.addListener(
         this.onFileChanged_.bind(this));
 
-    var self = this;
-
     // The list of callbacks to be invoked during the directory rescan after
     // all paste tasks are complete.
     this.pasteSuccessCallbacks_ = [];
 
     this.setupCurrentDirectory_();
 
     this.summarizeSelection_();
 
     var sortField = 'cachedMtime_';
     var sortDirection = 'desc';
     if (FileManager.DialogType.isModal(this.dialogType_)) {
       sortField =
           window.localStorage['sort-field-' + this.dialogType_] ||
           sortField;
       sortDirection =
           window.localStorage['sort-direction-' + this.dialogType_] ||
           sortDirection;
     }
     this.directoryModel_.fileList.sort(sortField, sortDirection);
 
     this.refocus();
 
     this.createMetadataProvider_();
 
-    this.table_.list.endBatchUpdates();
+    this.table_.endBatchUpdates();
     this.grid_.endBatchUpdates();
 
     metrics.recordInterval('Load.DOM');
     metrics.recordInterval('Load.Total');
   };
 
   /**
    * One-time initialization of commands.
    */
   FileManager.prototype.initCommands_ = function() {
@@ skipping 188 matching lines @@
 
     var self = this;
     this.rootsList_.itemConstructor = function(entry) {
       return self.renderRoot_(entry);
     };
 
     this.rootsList_.selectionModel = this.directoryModel_.rootsListSelection;
 
     // TODO(dgozman): add "Add a drive" item.
     this.rootsList_.dataModel = this.directoryModel_.rootsList;
-    this.directoryModel_.updateRoots();
+    this.directoryModel_.updateRoots(function() {
+          self.rootsList_.endBatchUpdates();

[arv (Not doing code reviews), 2012/02/28 20:26:32]

this.directoryModel_.updateRoots(function() {
  self.rootsList_.endBatchUpdates();
});

[Rick Byers, 2012/02/28 20:35:00]

Done.

+        });
   };
 
   /**
    * Get the icon type for a given Entry.
    *
    * @param {Entry} entry An Entry subclass (FileEntry or DirectoryEntry).
    * @return {string}
    */
   FileManager.prototype.getIconType = function(entry) {
     if (!('cachedIconType_' in entry))
@@ skipping 608 matching lines @@
 
   /**
    * Restores current directory and may be a selected item after page load (or
    * reload) or popping a state (after click on back/forward). If location.hash
    * is present it means that the user has navigated somewhere and that place
    * will be restored. defaultPath primarily is used with save/open dialogs.
    * Default path may also contain a file name. Freshly opened file manager
    * window has neither.
    */
   FileManager.prototype.setupCurrentDirectory_ = function() {
+    // Avoid a bunch of intermediate list redraws while the data model is
+    // cleared and updated.
+    this.table_.startBatchUpdates();
+    var onLoaded = function() {

[arv (Not doing code reviews), 2012/02/28 20:26:32]

or

var onLoaded = this.table_.endBatchUpdates.bind(this.table_);

[Rick Byers, 2012/02/28 20:35:00]

Done.

+      this.table_.endBatchUpdates();
+    }.bind(this);
+
     if (location.hash) {
       // Location hash has the highest priority.
       var path = decodeURI(location.hash.substr(1));
-      this.directoryModel_.setupPath(path);
+      this.directoryModel_.setupPath(path, onLoaded);
       return;
     } else if (this.params_.defaultPath) {
       var pathResolvedCallback;
       if (this.dialogType_ == FileManager.DialogType.SELECT_SAVEAS_FILE) {
         pathResolvedCallback = function(basePath, leafName) {
           this.filenameInput_.value = leafName;
           this.selectDefaultPathInFilenameInput_();
         }.bind(this);
       }
       this.directoryModel_.setupPath(this.params_.defaultPath,
+                                     onLoaded,
                                      pathResolvedCallback);
     } else {
-      this.directoryModel_.setupDefaultPath();
+      this.directoryModel_.setupDefaultPath(onLoaded);
     }
   };
 
   /**
    * Tweak the UI to become a particular kind of dialog, as determined by the
    * dialog type parameter passed to the constructor.
    */
   FileManager.prototype.initDialogType_ = function() {
     var defaultTitle;
     var okLabel = str('OPEN_LABEL');
@@ skipping 858 matching lines @@
   };
 
   /**
    * Event handler called when some volume was mounted or unmouted.
    */
   FileManager.prototype.onMountCompleted_ = function(event) {
     var self = this;
     chrome.fileBrowserPrivate.getMountPoints(function(mountPoints) {
       self.mountPoints_ = mountPoints;
       self.updateVolumeMetadata_();
-      var changeDirectoryTo = null;
+      var changeDirectoryCallback = null;
 
       if (event.eventType == 'mount') {
         // Mount request finished - remove it.
         var index = self.mountRequests_.indexOf(event.sourceUrl);
         if (index != -1) {
           self.mountRequests_.splice(index, 1);
           // Go to mounted directory, if request was initiated from this tab.
           if (event.status == 'success')
             changeDirectoryTo = event.mountPath;
         }
@@ skipping 23 matching lines @@
       if (event.eventType == 'unmount' && event.status == 'success' &&
           event.mountPath == self.directoryModel_.rootPath) {
         if (self.params_.mountTriggered) {
           // window.close() sometimes doesn't work.
           chrome.tabs.getCurrent(function(tab){
             chrome.tabs.remove(tab.id);
           });
           return;
         }
         // Current durectory just unmounted. Move to the 'Downloads'.
-        changeDirectoryTo = '/' + DirectoryModel.DOWNLOADS_DIRECTORY;
+        changeDirectoryCallback = function() {
+          self.directoryModel_.changeDirectory(
+              '/' + DirectoryModel.DOWNLOADS_DIRECTORY);
+        };
       }
 
       // Even if something failed root list should be rescanned.
       // Failed mounts can "give" us new devices which might be formatted,
       // so we have to refresh root list then.
-      self.directoryModel_.updateRoots(changeDirectoryTo);
+      self.directoryModel_.updateRoots(changeDirectoryCallback);
     });
   };
 
   /**
    * Event handler called when some internal task should be executed.
    */
   FileManager.prototype.onFileTaskExecute_ = function(id, details) {
     var urls = details.urls;
     if (id == 'play') {
       var position = 0;
@@ skipping 1475 matching lines @@
           });
       }, onError);
 
       function onError(err) {
         console.log('Error while checking free space: ' + err);
         setTimeout(doCheck, 1000 * 60);
       }
     }
   }
 })();