Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5466)

Unified Diff: chrome/browser/search_engines/template_url_service.cc

Issue 9379008: Add origin-based deletion to BrowsingDataRemover (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebasing to ToT. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service.cc
diff --git a/chrome/browser/search_engines/template_url_service.cc b/chrome/browser/search_engines/template_url_service.cc
index e89b9e35ee7442c93826cb71d49f743c358f8d6b..6c1a93b0530f2245fe7106870f167e47499fc1fd 100644
--- a/chrome/browser/search_engines/template_url_service.cc
+++ b/chrome/browser/search_engines/template_url_service.cc
@@ -325,12 +325,26 @@ void TemplateURLService::Remove(const TemplateURL* template_url) {
void TemplateURLService::RemoveAutoGeneratedBetween(base::Time created_after,
base::Time created_before) {
+ RemoveAutoGeneratedForOriginBetween(created_after, created_before, GURL());
+}
+
+void TemplateURLService::RemoveAutoGeneratedSince(base::Time created_after) {
+ RemoveAutoGeneratedForOriginBetween(created_after, base::Time(), GURL());
+}
+
+void TemplateURLService::RemoveAutoGeneratedForOriginBetween(
+ base::Time created_after,
+ base::Time created_before,
+ const GURL& origin) {
+ GURL o(origin.GetOrigin());
bool should_notify = false;
for (size_t i = 0; i < template_urls_.size();) {
if (template_urls_[i]->date_created() >= created_after &&
(created_before.is_null() ||
template_urls_[i]->date_created() < created_before) &&
- CanReplace(template_urls_[i])) {
+ CanReplace(template_urls_[i]) &&
+ (o.is_empty() ||
+ GenerateSearchURL(template_urls_[i]).GetOrigin() == o)) {
RemoveNoNotify(template_urls_[i]);
should_notify = true;
} else {
@@ -341,9 +355,6 @@ void TemplateURLService::RemoveAutoGeneratedBetween(base::Time created_after,
NotifyObservers();
}
-void TemplateURLService::RemoveAutoGeneratedSince(base::Time created_after) {
- RemoveAutoGeneratedBetween(created_after, base::Time());
-}
void TemplateURLService::RegisterExtensionKeyword(const Extension* extension) {
// TODO(mpcomplete): disable the keyword when the extension is disabled.

Powered by Google App Engine
This is Rietveld 408576698