Add origin-based deletion to BrowsingDataRemover

chrome/browser/search_engines/template_url_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/search_engines/template_url_service.h"
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/i18n/case_conversion.h"
@@ skipping 301 matching lines @@
   NotifyObservers();
 }
 
 void TemplateURLService::Remove(const TemplateURL* template_url) {
   RemoveNoNotify(template_url);
   NotifyObservers();
 }
 
 void TemplateURLService::RemoveAutoGeneratedBetween(base::Time created_after,
                                                     base::Time created_before) {
+  RemoveAutoGeneratedForOriginBetween(created_after, created_before, GURL());
+}
+
+void TemplateURLService::RemoveAutoGeneratedSince(base::Time created_after) {

[Peter Kasting, 2012/02/16 18:16:35]

Nit: I suggest implementing by chaining the call to the 2-arg version of
RemoveAutoGeneratedBetween() rather than the 3-arg version, which will make
future maintenance a tiny fraction easier.

If you do that it might also be fractionally clearer to reverse the order of
these first two functions here and in the header.

[Use mkwst_at_chromium.org plz., 2012/02/17 10:12:36]

Done.

+  RemoveAutoGeneratedForOriginBetween(created_after, base::Time(), GURL());
+}
+
+void TemplateURLService::RemoveAutoGeneratedForOriginBetween(
+    base::Time created_after,
+    base::Time created_before,
+    const GURL& origin) {

[Peter Kasting, 2012/02/16 18:16:35]

Nit: If you're going to name the function this way then put the arguments in the
same order -- first |origin|, then the times.

[Use mkwst_at_chromium.org plz., 2012/02/16 18:35:03]

If you have a suggestion for a different name, I'm happy to change it. This was
just the first thing I came up with, not a deeply considered evaluation. :)

[Use mkwst_at_chromium.org plz., 2012/02/17 10:12:36]

Done.

+  GURL o(origin.GetOrigin());
   bool should_notify = false;
   for (size_t i = 0; i < template_urls_.size();) {
     if (template_urls_[i]->date_created() >= created_after &&
         (created_before.is_null() ||
          template_urls_[i]->date_created() < created_before) &&
-        CanReplace(template_urls_[i])) {
+        CanReplace(template_urls_[i]) &&
+        (o.is_empty() ||
+         GenerateSearchURL(template_urls_[i]).GetOrigin() == o)) {
       RemoveNoNotify(template_urls_[i]);
       should_notify = true;
     } else {
       ++i;
     }
   }
   if (should_notify)
     NotifyObservers();
 }
 
-void TemplateURLService::RemoveAutoGeneratedSince(base::Time created_after) {
-  RemoveAutoGeneratedBetween(created_after, base::Time());
-}
 
 void TemplateURLService::RegisterExtensionKeyword(const Extension* extension) {
   // TODO(mpcomplete): disable the keyword when the extension is disabled.
   if (extension->omnibox_keyword().empty())
     return;
 
   Load();
   if (!loaded_) {
     pending_extension_ids_.push_back(extension->id());
     return;
@@ skipping 1541 matching lines @@
   dst->set_input_encodings(input_encodings);
   dst->set_show_in_default_list(specifics.show_in_default_list());
   dst->SetSuggestionsURL(specifics.suggestions_url(), 0, 0);
   dst->SetPrepopulateId(specifics.prepopulate_id());
   dst->set_autogenerate_keyword(specifics.autogenerate_keyword());
   dst->SetInstantURL(specifics.instant_url(), 0, 0);
   dst->set_last_modified(
       base::Time::FromInternalValue(specifics.last_modified()));
   dst->set_sync_guid(specifics.sync_guid());
 }