Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: content/renderer/pepper_plugin_delegate_impl.h

Issue 9379002: Move socket API restriction check to browser process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nit Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper_plugin_delegate_impl.h
diff --git a/content/renderer/pepper_plugin_delegate_impl.h b/content/renderer/pepper_plugin_delegate_impl.h
index d7ff48831ecd8786d924d4ae371b64bdb628e734..e441fcd3253cd47757de2e3436dcfc4f394e321a 100644
--- a/content/renderer/pepper_plugin_delegate_impl.h
+++ b/content/renderer/pepper_plugin_delegate_impl.h
@@ -433,16 +433,6 @@ class PepperPluginDelegateImpl
// Implementation of PepperParentContextProvider.
virtual ContentGLContext* GetParentContextForPlatformContext3D() OVERRIDE;
- // Helper function to check that TCP/UDP private APIs are allowed for current
- // page. This check actually allows socket usage for NativeClient code only.
- // It is better to move this check to browser process but Pepper message
- // filters in browser process have no context about page that sent
- // the request. Doing this check in render process is safe because NaCl code
- // is executed in separate NaCl process.
- // TODO(dpolukhin, yzshen): make the check consistent for in- and out-process
- // cases and do the check during socket creation in the browser process.
- bool CanUseSocketAPIs();
-
MouseLockDispatcher::LockTarget* GetOrCreateLockTargetAdapter(
webkit::ppapi::PluginInstance* instance);
void UnSetAndDeleteLockTargetAdapter(webkit::ppapi::PluginInstance* instance);

Powered by Google App Engine
This is Rietveld 408576698