Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: ppapi/tests/test_tcp_socket_private_disallowed.cc

Issue 9379002: Move socket API restriction check to browser process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_tcp_socket_private_disallowed.h ('k') | ppapi/tests/test_udp_socket_private_disallowed.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_tcp_socket_private_disallowed.cc
diff --git a/ppapi/tests/test_tcp_socket_private_disallowed.cc b/ppapi/tests/test_tcp_socket_private_disallowed.cc
index 11932927bf459987571937e235493bb556a03770..d4de2d4e9cd40a0ae1b5acbda8ae08d2337287d0 100644
--- a/ppapi/tests/test_tcp_socket_private_disallowed.cc
+++ b/ppapi/tests/test_tcp_socket_private_disallowed.cc
@@ -5,8 +5,16 @@
#include "ppapi/tests/test_tcp_socket_private_disallowed.h"
#include "ppapi/cpp/module.h"
+#include "ppapi/tests/test_utils.h"
#include "ppapi/tests/testing_instance.h"
+namespace {
+
+const char kServerName[] = "www.google.com";
+const int kPort = 80;
+
+}
+
REGISTER_TEST_CASE(TCPSocketPrivateDisallowed);
TestTCPSocketPrivateDisallowed::TestTCPSocketPrivateDisallowed(
@@ -23,15 +31,23 @@ bool TestTCPSocketPrivateDisallowed::Init() {
}
void TestTCPSocketPrivateDisallowed::RunTests(const std::string& filter) {
- RUN_TEST(Create, filter);
+ RUN_TEST(Connect, filter);
}
-std::string TestTCPSocketPrivateDisallowed::TestCreate() {
+std::string TestTCPSocketPrivateDisallowed::TestConnect() {
PP_Resource socket =
tcp_socket_private_interface_->Create(instance_->pp_instance());
if (0 != socket) {
- return "PPB_TCPSocket_Private::Create returns valid socket " \
- "without allowing switch";
+ TestCompletionCallback callback(instance_->pp_instance());
+ int32_t rv = tcp_socket_private_interface_->Connect(
+ socket, kServerName, kPort,
+ static_cast<pp::CompletionCallback>(callback).pp_completion_callback());
+
+ if (PP_OK_COMPLETIONPENDING == rv)
+ rv = callback.WaitForResult();
+
+ if (PP_ERROR_FAILED != rv)
+ return "PPB_TCPSocket_Private can connect without allowing switch";
}
PASS();
}
« no previous file with comments | « ppapi/tests/test_tcp_socket_private_disallowed.h ('k') | ppapi/tests/test_udp_socket_private_disallowed.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698