Get IPC working for Indexed DB in shared workers.

content/renderer/indexed_db/indexed_db_dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/indexed_db/indexed_db_dispatcher.h"
 
 #include "base/lazy_instance.h"
 #include "base/threading/thread_local.h"
 #include "content/common/indexed_db/indexed_db_messages.h"
 #include "content/renderer/indexed_db/renderer_webidbcursor_impl.h"
@@ skipping 163 matching lines @@
 void IndexedDBDispatcher::RequestIDBFactoryOpen(
     const string16& name,
     WebIDBCallbacks* callbacks_ptr,
     const string16& origin,
     WebFrame* web_frame) {
   ResetCursorPrefetchCaches();
   scoped_ptr<WebIDBCallbacks> callbacks(callbacks_ptr);
 
   if (!web_frame)
     return; // We must be shutting down.
-  RenderViewImpl* render_view = RenderViewImpl::FromWebView(web_frame->view());

[dgrogan, 2012/02/09 22:46:06]

This always fails in the shared worker.  I would have thought that there would
no webFrame in the shared worker either but apparently there is.

I don't know how useful this check was in the renderer, anyway.

[jsbell, 2012/02/09 23:23:56]

Being paranoid, I see this pattern used in a few other places for similar early
exit.... jam@ ?

[michaeln, 2012/02/09 23:59:40]

These render_view checks are probably here for good reason (script running in a
detached iframe?) and probably shouldn't be removed without understanding that
reason. You can distinguish between the 'worker' vs 'document' case by looking
at the value of CurrentWorkerId(). We should be able to conditionally skip the
sanity-tests for web_frame/render_view in the worker case.

The non-null value of 'web_frame' in the worker case comes from
IDBFactoryBackendProxy.

void IDBFactoryBackendProxy::openFromWorker(const String& name, IDBCallbacks*
callbacks, PassRefPtr<SecurityOrigin> prpOrigin, WorkerContext* context, const
String& dataDir)
{
#if ENABLE(WORKERS)
    WebSecurityOrigin origin(prpOrigin);
    if (!allowIDBFromWorkerThread(context, name, origin)) {
        callbacks->onError(WebIDBDatabaseError(0, "The user denied permission to
access the database."));
        return;
    }
    WorkerLoaderProxy* workerLoaderProxy =
&context->thread()->workerLoaderProxy();
    WebWorkerBase* webWorker = static_cast<WebWorkerBase*>(workerLoaderProxy);
    WebFrame* webFrame = webWorker->view()->mainFrame();
    m_webIDBFactory->open(name, new WebIDBCallbacksImpl(callbacks), origin,
webFrame, dataDir);
#endif
}

Since we're on the worker context thread, it'd probably be safer to pass NULL
for webFrame at this callsite since WebFrame is not thread-safe.

-  if (!render_view)
-    return; // We must be shutting down.
 
   IndexedDBHostMsg_FactoryOpen_Params params;
   params.thread_id = CurrentWorkerId();
   params.response_id = pending_callbacks_.Add(callbacks.release());
   params.origin = origin;
   params.name = name;
   Send(new IndexedDBHostMsg_FactoryOpen(params));
 }
 
 void IndexedDBDispatcher::RequestIDBFactoryGetDatabaseNames(
     WebIDBCallbacks* callbacks_ptr,
     const string16& origin,
     WebFrame* web_frame) {
   ResetCursorPrefetchCaches();
   scoped_ptr<WebIDBCallbacks> callbacks(callbacks_ptr);
 
   if (!web_frame)
     return; // We must be shutting down.
   RenderViewImpl* render_view = RenderViewImpl::FromWebView(web_frame->view());

[jsbell, 2012/02/09 23:23:56]

Remove here too, even though this isn't supported in workers yet?

   if (!render_view)
     return; // We must be shutting down.
 
   IndexedDBHostMsg_FactoryGetDatabaseNames_Params params;
   params.thread_id = CurrentWorkerId();
   params.response_id = pending_callbacks_.Add(callbacks.release());
   params.origin = origin;
   Send(new IndexedDBHostMsg_FactoryGetDatabaseNames(params));
 }
 
 void IndexedDBDispatcher::RequestIDBFactoryDeleteDatabase(
     const string16& name,
     WebIDBCallbacks* callbacks_ptr,
     const string16& origin,
     WebFrame* web_frame) {
   ResetCursorPrefetchCaches();
   scoped_ptr<WebIDBCallbacks> callbacks(callbacks_ptr);
 
   if (!web_frame)
     return; // We must be shutting down.
   RenderViewImpl* render_view = RenderViewImpl::FromWebView(web_frame->view());

[jsbell, 2012/02/09 23:23:56]

And here? If not useful, should get rid of it everywhere. (And if it's needed,
this might tickle tests.)

   if (!render_view)
     return; // We must be shutting down.
 
   IndexedDBHostMsg_FactoryDeleteDatabase_Params params;
   params.thread_id = CurrentWorkerId();
   params.response_id = pending_callbacks_.Add(callbacks.release());
   params.origin = origin;
   params.name = name;
   Send(new IndexedDBHostMsg_FactoryDeleteDatabase(params));
 }
@@ skipping 442 matching lines @@
 }
 
 void IndexedDBDispatcher::ResetCursorPrefetchCaches(int32 exception_cursor_id) {
   typedef std::map<int32, RendererWebIDBCursorImpl*>::iterator Iterator;
   for (Iterator i = cursors_.begin(); i != cursors_.end(); ++i) {
     if (i->first == exception_cursor_id)
       continue;
     i->second->ResetPrefetchCache();
   }
 }